0045618: Not possible to click several buttons after an addProduct

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045618

Retail Modules

Web POS

public

2020-12-15 18:37

2020-12-18 06:47

Reporter

guillermogil

Assigned To

prakashmurugesan88

Priority

immediate

Severity

critical

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

RR19Q3.3

Target Version

RR20Q3.3

Fixed in Version

RR20Q3.3

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045618: Not possible to click several buttons after an addProduct

Description

Not possible to click several buttons after an addProduct.
There are several exceptions in the code that avoid to finish the addProdct functionality but the ProcessController is never closed.

e.g.-
in _addProduct:

                  if (OB.MobileApp.model.get('inPaymentTab')) {
                    if (args.options && args.options.blockAddProduct) {
                      OB.error(
                        'An add product is executed. At this point, this action is not allowed. Skipping product ' +
                          p.get('_identifier')
                      );
                      if (args && args.attrs && args.attrs.obposEpccode) {
                        OB.UTIL.RfidController.removeEpc(
                          args.attrs.obposEpccode
                        );
                      }
                      return;
                    }
                  }
That returns breaks the flow as it is not executing the finalCallback.
There are several other cases across the code.

The code is still the same on PI although it is on the legacy function. Releases <20Q4 will have this issue in the case exposed.

Steps To Reproduce

Do an addProduct in the payment tab
ProcessController starts
Log is raised: An add product is executed. At this point, this action is not allowed. Skipping product
Process controller is never finished

After that you get the 120s timeout from the ProcessController
Buttons are deactivated forever

Proposed Solution

Return the callback on the _addProduct with the success as false

Additional Information