Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045589Retail ModulesWeb POSpublic2020-12-15 18:372020-12-18 06:46
Reporterguillermogil 
Assigned Toprakashmurugesan88 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR19Q3.3 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045589: Not possible to click several buttons after an addProduct
DescriptionNot possible to click several buttons after an addProduct.
There are several exceptions in the code that avoid to finish the addProdct functionality but the ProcessController is never closed.

e.g.-
in _addProduct:

                  if (OB.MobileApp.model.get('inPaymentTab')) {
                    if (args.options && args.options.blockAddProduct) {
                      OB.error(
                        'An add product is executed. At this point, this action is not allowed. Skipping product ' +
                          p.get('_identifier')
                      );
                      if (args && args.attrs && args.attrs.obposEpccode) {
                        OB.UTIL.RfidController.removeEpc(
                          args.attrs.obposEpccode
                        );
                      }
                      return;
                    }
                  }
That returns breaks the flow as it is not executing the finalCallback.
There are several other cases across the code.

The code is still the same on PI although it is on the legacy function. Releases <20Q4 will have this issue in the case exposed.
Steps To ReproduceDo an addProduct in the payment tab
ProcessController starts
Log is raised: An add product is executed. At this point, this action is not allowed. Skipping product
Process controller is never finished

After that you get the 120s timeout from the ProcessController
Buttons are deactivated forever
Proposed SolutionReturn the callback on the _addProduct with the success as false
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045617RR20Q4.2 closed prakashmurugesan88 Not possible to click several buttons after an addProduct 
depends on backport 0045618RR20Q3.3 closed prakashmurugesan88 Not possible to click several buttons after an addProduct 
Attached Filespatch I45589_19Q3_V2.patch (5,423) 2020-12-17 16:38
https://issues.openbravo.com/file_download.php?file_id=15188&type=bug
patch I45589_19Q4_V2.patch (5,380) 2020-12-17 16:49
https://issues.openbravo.com/file_download.php?file_id=15189&type=bug
patch I45589_20Q1_20Q2_V2.patch (5,183) 2020-12-17 17:33
https://issues.openbravo.com/file_download.php?file_id=15191&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-12-15 18:37guillermogilNew Issue
2020-12-15 18:37guillermogilAssigned To => Retail
2020-12-15 18:37guillermogilResolution time => 1608246000
2020-12-15 18:37guillermogilTriggers an Emergency Pack => No
2020-12-15 18:45guillermogilDescription Updatedbug_revision_view_page.php?rev_id=21944#r21944
2020-12-16 05:45prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-12-16 06:05prakashmurugesan88Statusnew => scheduled
2020-12-17 05:08prakashmurugesan88File Added: I45589_20Q3.patch
2020-12-17 07:14prakashmurugesan88File Deleted: I45589_20Q3.patch
2020-12-17 07:14prakashmurugesan88File Added: I45589_20Q3_20Q2_20Q1.patch
2020-12-17 07:14prakashmurugesan88File Added: I45589_19Q4.patch
2020-12-17 07:14prakashmurugesan88File Added: I45589_19Q3.patch
2020-12-17 10:37prakashmurugesan88Statusscheduled => acknowledged
2020-12-17 10:38prakashmurugesan88Statusacknowledged => scheduled
2020-12-17 10:48hgbotNote Added: 0124895
2020-12-17 16:38prakashmurugesan88File Deleted: I45589_19Q3.patch
2020-12-17 16:38prakashmurugesan88File Added: I45589_19Q3_V2.patch
2020-12-17 16:38prakashmurugesan88File Deleted: I45589_19Q4.patch
2020-12-17 16:49prakashmurugesan88File Added: I45589_19Q4_V2.patch
2020-12-17 17:28prakashmurugesan88File Added: I45589_20Q1_V2.patch
2020-12-17 17:33prakashmurugesan88File Deleted: I45589_20Q3_20Q2_20Q1.patch
2020-12-17 17:33prakashmurugesan88File Deleted: I45589_20Q1_V2.patch
2020-12-17 17:33prakashmurugesan88File Added: I45589_20Q1_20Q2_V2.patch
2020-12-18 06:46hgbotResolutionopen => fixed
2020-12-18 06:46hgbotStatusscheduled => closed
2020-12-18 06:46hgbotNote Added: 0124907
2020-12-18 06:46hgbotFixed in Version => RR21Q1
2020-12-18 06:46hgbotNote Added: 0124908

Notes
(0124895)
hgbot   
2020-12-17 10:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/221 [^]
(0124907)
hgbot   
2020-12-18 06:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/221 [^]
(0124908)
hgbot   
2020-12-18 06:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9279ebd20b374e2a1d9095183a383b9be435a1cc
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-12-17T14:54:31+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9279ebd20b374e2a1d9095183a383b9be435a1cc [^]

Fixed BUG-45589: Fixes process timeout when error raised in addProduct
* Added callback with success as false to handle process completion

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---