Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045577Retail ModulesWeb POSpublic2020-12-15 11:302020-12-30 19:16
gorkaion 
prakashmurugesan88 
highmajoralways
closedfixed 
5
 
RR21Q1 
No
0045577: Product wrongly grouped after clicking on return line
A product flagged as grouping enabled is wrongly grouped when the return line button is pressed twice.

When you are creating a ticket to exchange a product you might end up with a ticket with a single line of 0 quantity and total amount.
Use a product that has the grouping enabled. For example Headlamp ultralight

1. Add the product and click on return line
2. Add again the product
3. There are 2 lines positive and negative.
4. Click on return line on the positive line.
5. There are 2 lines both negative.
6. Click again on return line of the 1st line added.
7. Instead of having 2 lines positive and negative the lines are grouped on a single line of 0 quantity.

This is wrong. Expected behavior is to have 2 lines positive and negative.
There are at least 2 options.

1. Ensure that after the return line is clicked on a return line the lines are not grouped. This is already happening when the return line button is clicked the first time.
2. Disable the return line button on a line that it is already a return.

Preferred option is the 1st one as the last would require to delete the line and add it again.
No tags attached.
Issue History
2020-12-15 11:30gorkaionNew Issue
2020-12-15 11:30gorkaionAssigned To => Retail
2020-12-15 11:30gorkaionResolution time => 1609801200
2020-12-15 11:30gorkaionTriggers an Emergency Pack => No
2020-12-23 05:57prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-12-24 03:59prakashmurugesan88Statusnew => scheduled
2020-12-28 07:07hgbotNote Added: 0125092
2020-12-28 07:07hgbotNote Added: 0125093
2020-12-30 19:16hgbotResolutionopen => fixed
2020-12-30 19:16hgbotStatusscheduled => closed
2020-12-30 19:16hgbotNote Added: 0125184
2020-12-30 19:16hgbotFixed in Version => RR21Q1
2020-12-30 19:16hgbotNote Added: 0125185
2020-12-30 19:16hgbotNote Added: 0125186
2020-12-30 19:16hgbotNote Added: 0125187

Notes
(0125092)
hgbot   
2020-12-28 07:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/233 [^]
(0125093)
hgbot   
2020-12-28 07:07   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/64 [^]
(0125184)
hgbot   
2020-12-30 19:16   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/233 [^]
(0125185)
hgbot   
2020-12-30 19:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 61d293c3a9b46351a68340221ae09d934f004890
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-12-30T18:16:35+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/61d293c3a9b46351a68340221ae09d934f004890 [^]

Fixed BUG-45577: Fixed by preventing merge of positive and negative line

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0125186)
hgbot   
2020-12-30 19:16   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 78bf8f8590c21ac8aa9d909b6ce1ce0b6b692b09
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-12-30T18:16:47+00:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/78bf8f8590c21ac8aa9d909b6ce1ce0b6b692b09 [^]

Related to BUG-45577: Verifies positive and negative lines cannot be merged

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I45577_VerifyPositiveAndNegativeLinesAreNotGrouped.java
---
(0125187)
hgbot   
2020-12-30 19:16   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/64 [^]