0045564: Service workers infrastructure precaches CSS files that are then never used

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045564

Retail Modules

Web POS

public

2020-12-14 08:29

2020-12-28 07:27

Reporter

marvintm

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR20Q4.1

Fixed in Version

RR20Q4.1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045564: Service workers infrastructure precaches CSS files that are then never used

Description

Currently there is code inside the Service workers/AppCacheManifest infrastructure that adds CSS files belonging to external modules automatically to the Manifest as separate requests:

MobileCoreApplicationCacheComponent.java: method getcssFileList()
cache-manifest-ftl <#list data.cssFileList as cssFile>
${cssFile}
</#list>

This causes the Service Worker to request and store those files separately. However, the WebPOS application then never formally requests them, as their content is already present inside the main StyleSheetResources request.

Therefore, we are wasting quite a bit of bandwidth and triggering many unnecessary requests.

Steps To Reproduce

Go to livebuilds and access the modules instance. Check in developer tools and see that many css requests exist separately, coming from the Service Worker.

Then reload the page (F5), and realise that those css files are never actually requested by the application.

Proposed Solution

Delete both the getcssFileList method inside MobileCoreApplicationCacheComponent.java and the corresponding CSS section inside cache-manifest-ftl

Additional Information