Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045560Retail ModulesWeb POSpublic2020-12-11 14:562020-12-21 15:34
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045560: Several ClientModel requests are done twice
DescriptionWhen the WebPOS application is loaded, the following requests are done twice:

ClientModel?entity=FinancialMgmtTaxRate
ClientModel?entity=PricingAdjustment
ClientModel?entity=PricingAdjustmentBusinessPartner
ClientModel?entity=PricingAdjustmentBusinessPartner
ClientModel?entity=PricingAdjustmentProduct
ClientModel?entity=PricingAdjustmentProductCategory
ClientModel?entity=OBDISC_Offer_Role
ClientModel?entity=PricingAdjustmentCharacteristic

Moreover, the first group of requests seems not to be cached (second group is triggered by the Service Workers).

We need to remove the first group.
Steps To ReproduceLoad the WebPOS, and realise those requests are duplicated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045570RR20Q4.1 closed ranjith_qualiantech_com Several ClientModel requests are done twice 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-12-11 14:56marvintmNew Issue
2020-12-11 14:56marvintmAssigned To => Retail
2020-12-11 14:56marvintmOBNetwork customer => No
2020-12-11 14:56marvintmTriggers an Emergency Pack => No
2020-12-11 14:58marvintmResolution time => 1609369200
2020-12-14 07:29marvintmOBNetwork customerNo => Gold
2020-12-14 11:54shuehnerStatusnew => scheduled
2020-12-15 04:53ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-12-16 06:47hgbotMerge Request Status => open
2020-12-16 06:47hgbotNote Added: 0124847
2020-12-16 09:09hgbotMerge Request Statusopen => approved
2020-12-16 09:10hgbotResolutionopen => fixed
2020-12-16 09:10hgbotStatusscheduled => closed
2020-12-16 09:10hgbotNote Added: 0124870
2020-12-16 09:10hgbotFixed in Version => RR21Q1
2020-12-16 09:10hgbotNote Added: 0124871
2020-12-16 09:10marvintmNote Added: 0124872
2020-12-16 15:18marvintmNote Deleted: 0124872
2020-12-18 05:42hgbotNote Added: 0124903
2020-12-18 05:42hgbotNote Added: 0124904
2020-12-18 05:42hgbotNote Added: 0124905
2020-12-18 05:42hgbotNote Added: 0124906
2020-12-18 07:00hgbotNote Added: 0124915
2020-12-18 07:00hgbotNote Added: 0124916
2020-12-18 07:00hgbotNote Added: 0124917
2020-12-18 07:00hgbotNote Added: 0124918
2020-12-18 07:00hgbotNote Added: 0124919
2020-12-18 07:00hgbotNote Added: 0124920
2020-12-18 07:01hgbotNote Added: 0124921
2020-12-18 07:01hgbotNote Added: 0124922
2020-12-20 16:18hgbotNote Added: 0125009
2020-12-21 14:01hgbotNote Added: 0125018
2020-12-21 15:34hgbotNote Added: 0125021
2020-12-21 15:34hgbotNote Added: 0125022

Notes
(0124847)
hgbot   
2020-12-16 06:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/218 [^]
(0124870)
hgbot   
2020-12-16 09:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/218 [^]
(0124871)
hgbot   
2020-12-16 09:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4b06a72bd62035958502d233df4353447b066a4a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-16T08:09:58+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4b06a72bd62035958502d233df4353447b066a4a [^]

Fixed ISSUE-45560: Removed unused promotion model form Component Provider

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
R web/org.openbravo.retail.posterminal/js/model/promotions.js
---
(0124903)
hgbot   
2020-12-18 05:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/225 [^]
(0124904)
hgbot   
2020-12-18 05:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/3 [^]
(0124905)
hgbot   
2020-12-18 05:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/6 [^]
(0124906)
hgbot   
2020-12-18 05:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/merge_requests/2 [^]
(0124915)
hgbot   
2020-12-18 07:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice [^]
Changeset: e6f91c06ac9dc715a31d2f059afd28f3cea4c3bc
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-17T12:03:24+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/commit/e6f91c06ac9dc715a31d2f059afd28f3cea4c3bc [^]

Related to ISSUE-45560: Removed ClientModel as it no longer needed

---
R src/org/openbravo/retail/discounts/scaledprice/DiscountsScaledPriceAppCacheProvider.java
---
(0124916)
hgbot   
2020-12-18 07:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.scaledprice/-/merge_requests/2 [^]
(0124917)
hgbot   
2020-12-18 07:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 372a764ed88850fb0fb5815e558471c6866501f0
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-17T12:03:22+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/372a764ed88850fb0fb5815e558471c6866501f0 [^]

Related to ISSUE-45560: Removed ClientModel as it no longer needed

---
R src/org/openbravo/retail/discounts/combo/master/CombosAppCacheProvider.java
---
(0124918)
hgbot   
2020-12-18 07:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/6 [^]
(0124919)
hgbot   
2020-12-18 07:00   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal [^]
Changeset: 51aba72ae59e1f5351b731d51bf4ea5658d77eee
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-17T12:03:26+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/commit/51aba72ae59e1f5351b731d51bf4ea5658d77eee [^]

Related to ISSUE-45560: Removed ClientModel as it no longer needed

---
R src/org/openbravo/retail/discounts/bytotal/master/DiscountsByTotalAppCacheProvider.java
---
(0124920)
hgbot   
2020-12-18 07:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.bytotal/-/merge_requests/3 [^]
(0124921)
hgbot   
2020-12-18 07:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 03c7a2e02c70de9508ca06953832214a64184be0
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-18T06:01:08+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/03c7a2e02c70de9508ca06953832214a64184be0 [^]

Related to ISSUE-45560: Removed ClientModel as it no longer needed

---
M src/org/openbravo/retail/posterminal/ApplicationCacheComponent.java
---
(0124922)
hgbot   
2020-12-18 07:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/225 [^]
(0125009)
hgbot   
2020-12-20 16:18   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3c6f464d2732559fcbde3647afda138d88e4bcc4
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-20T20:48:06+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3c6f464d2732559fcbde3647afda138d88e4bcc4 [^]

Related to ISSUE-45560: Reverse Commit

---
A web/org.openbravo.retail.posterminal/js/model/promotions.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
---
(0125018)
hgbot   
2020-12-21 14:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/228 [^]
(0125021)
hgbot   
2020-12-21 15:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2b07aeddfed99567b315c8351fdcedf5db6d84b7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-21T12:55:26+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2b07aeddfed99567b315c8351fdcedf5db6d84b7 [^]

Fixed ISSUE-45560: Added DataModel for DiscountFilter Business Partner
* Removed unused promotion model form Component Provider

---
A web/org.openbravo.retail.posterminal/js/model/discountsbusinesspartner.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
R web/org.openbravo.retail.posterminal/js/model/promotions.js
---
(0125022)
hgbot   
2020-12-21 15:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/228 [^]