Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045558Retail ModulesWeb POSpublic2020-12-11 14:492020-12-17 03:32
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045558: ClientModel request should return 304 http code if it did not change
DescriptionCurrently the ClientModel request is cached in the server, but it always returns the full definition of the model even if the content itself didn't change compared to the last time it was requested.

An Etag should be defined for it, so that if the content did not change, a 304 http code is returned, and we don't consume bandwidth needlessly.
Steps To ReproduceAccess the WebPOS.

Reload the page immediately. Verify that a request to the ClientModel servlet is done again, and the content is returned by the server. This part should be improved, so that the content is not fully returned if it is the same.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045572RR20Q4.1 closed ranjith_qualiantech_com ClientModel request should return 304 http code if it did not change 
depends on backport 0045573RR20Q3.3 closed ranjith_qualiantech_com ClientModel request should return 304 http code if it did not change 
Attached Filesdiff 45558_20Q1_mobilecore.diff (2,176) 2020-12-17 03:32
https://issues.openbravo.com/file_download.php?file_id=15172&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-12-11 14:49marvintmNew Issue
2020-12-11 14:49marvintmAssigned To => Retail
2020-12-11 14:49marvintmTriggers an Emergency Pack => No
2020-12-11 14:57marvintmResolution time => 1609369200
2020-12-14 11:56shuehnerStatusnew => scheduled
2020-12-15 04:54ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-12-16 06:45hgbotNote Added: 0124845
2020-12-16 09:34hgbotNote Added: 0124875
2020-12-16 09:34hgbotResolutionopen => fixed
2020-12-16 09:34hgbotStatusscheduled => closed
2020-12-16 09:34hgbotFixed in Version => RR21Q1
2020-12-16 09:34hgbotNote Added: 0124876
2020-12-17 03:32ranjith_qualiantech_comFile Added: 45558_20Q1_mobilecore.diff

Notes
(0124845)
hgbot   
2020-12-16 06:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/111 [^]
(0124875)
hgbot   
2020-12-16 09:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/111 [^]
(0124876)
hgbot   
2020-12-16 09:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 6d78c47a5a25ecddd3d1d920f5f09956aa28cf50
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-16T08:34:14+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/6d78c47a5a25ecddd3d1d920f5f09956aa28cf50 [^]

Fixed ISSUE-45558: Updated Etag to hash of ClientModel content

---
M src/org/openbravo/mobile/core/model/ClientModelComponent.java
---