0045545: Cancel and Replace process fails when the new ticket has a total amount of zero

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045545

Retail Modules

Web POS

public

2020-12-09 12:06

2020-12-16 07:35

Reporter

aaroncalero

Assigned To

markmm82

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR21Q1

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045545: Cancel and Replace process fails when the new ticket has a total amount of zero

Description

When executing the cancel and replace process, if the final ticket has a total gross amount of zero, the process fails and a record is generated in the Errors While Importing POS Data window.

Steps To Reproduce

First, log in backend and configure the following:
* Go to the Preference Window and make sure that the preference 'Web POS Enable Delivery Modes' is defined with value Y.
* Go to the Channel - Touchpoint window, find the VBS-1 record and navigate to its Touchpoint Type. Enable the 'Allow prepayments and partialpayments' check, and save the record.

Log in WebPOS terminal VBS-1
Create a new ticket
Add a product (i.e. Avalanche Transceiver)
Click on the Total Amount button and click on Done to complete the ticket. Approve the action if required.
Open the created ticket.
Click on the Menu, then on Cancel and Replace.
Change the price of the Avalanche Transceiver to 0.
Click on the Total Amount button and click on Done to complete the ticket again.

Verify in backend that a new record appears in the Errors While Importing POS Data window with the following error:
org.openbravo.base.exception.OBException: CancelAndReplaceUtils.cancelAndReplaceOrder:
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:545)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:201)
[...]
Caused by: org.openbravo.base.exception.OBException: org.openbravo.base.exception.OBException: java.lang.NullPointerException
    at org.openbravo.erpCommon.businessUtility.ReplaceOrderExecutor.cancelAndReplaceOrder(ReplaceOrderExecutor.java:167)
    at org.openbravo.erpCommon.businessUtility.ReplaceOrderExecutor.run(ReplaceOrderExecutor.java:107)

Proposed Solution

It seems that the problem happens when the final ticket doesn't have a Payment Schedule (since its total amount is 0 there is nothing to be paid)

Additional Information