Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045544Retail ModulesWeb POSpublic2020-12-09 09:402020-12-30 13:59
Reporteraferraz 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045544: Deactivating Discounts and Promotions | Include Characteristics filter doesn't deactivate the discount
DescriptionDeactivating Discounts and Promotions | Include Characteristics filter doesn't deactivate the discount
Steps To Reproduce- Login in https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
- Create a ticket with 3 units of Electronic Animal Repellent
- Check 3 x 2 Characteristic Battery Life 500h discount is applied

- Login in https://livebuilds.openbravo.com/retail_pi_pgsql [^]
- Open 3 x 2 Characteristic Battery Life 500h discount and promotion
- Deactivate the record in Include Characteristics tab with Battery Life - 500h max value

- Login in https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
- Click on Menu | Refresh data
- Create a ticket with 3 units of Electronic Animal Repellent
- Check 3 x 2 Characteristic Battery Life 500h discount is still applied and it should not
Proposed Solution
Additional Information
TagsNOR
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-12-09 09:40aferrazNew Issue
2020-12-09 09:40aferrazAssigned To => Retail
2020-12-09 09:40aferrazOBNetwork customer => Gold
2020-12-09 09:40aferrazResolution time => 1609282800
2020-12-09 09:40aferrazTriggers an Emergency Pack => No
2020-12-09 09:54aferrazTag Attached: NOR
2020-12-22 16:11ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-12-23 08:32hgbotMerge Request Status => open
2020-12-23 08:32hgbotNote Added: 0125056
2020-12-24 04:36ranjith_qualiantech_comStatusnew => scheduled
2020-12-30 13:59hgbotMerge Request Statusopen => approved
2020-12-30 13:59hgbotNote Added: 0125170
2020-12-30 13:59hgbotResolutionopen => fixed
2020-12-30 13:59hgbotStatusscheduled => closed
2020-12-30 13:59hgbotFixed in Version => RR21Q1
2020-12-30 13:59hgbotNote Added: 0125171

Notes
(0125056)
hgbot   
2020-12-23 08:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/12 [^]
(0125170)
hgbot   
2020-12-30 13:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/12 [^]
(0125171)
hgbot   
2020-12-30 13:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 4de51bdb92f232710e4b3ae13a507ed1c5022c5d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-30T12:59:43+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/4de51bdb92f232710e4b3ae13a507ed1c5022c5d [^]

Fixed ISSUE-45544: Discount should not be calculated if discount characteristics is not defined
* If Discount is configured with "Any of the one defined" include characteristics, discount will be applied only if any of the product characteristics should be present in the any of the characteristics in discount definition. Else discount will not be applied

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
---