Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045528ModulesFrench Fiscalpublic2020-12-01 09:542020-12-30 14:13
Reporterpsanjuan 
Assigned Tovmromanos 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0045528: Payment data needs to be included in archiving files
DescriptionPayment data needs to be included in archiving files
Steps To ReproduceGo to the Archiving Process window and define an archiving period for a given organization. Press Done.
Once French Fiscal Archiving process has succesffully finished, open the zip file generated.
Open the csv file OBCFR_Ticket.csv
Verify that the column json is empty
Proposed SolutionTicket Json needs to be exported.
It was not done in purpose due to performance issues.
To evaluate if the JSON file can be reduced somehow.
Payment data listed below is the data liste below:

Req 3
- the receipt number (or transaction number);
- the POS identifier 21 ;
- a unique identifier for the establishment using the cash register system;
- the date and time of the transaction (year, month, day, hour, minute);
- the total amount, including tax;
- any data that may be used to produce receipts (definitive or provisional);
- the payment method (and the details of the amounts paid per payment method if the payment was made via several payment methods);
- the payment date (if different to the transaction date);
- details of the items or services: name, quantity, unit price, total excluding - tax for the line - and associated rate of VAT.

These details must include any other basic data 22 needed to calculate the total excluding tax for the line.
- any data that may be used to ensure the traceability of the transaction and to guarantee the integrity of the payment data

Req 4
- corrections

Req 7

- cumulative and summary data
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-12-01 09:54psanjuanNew Issue
2020-12-01 09:54psanjuanAssigned To => Triage Finance
2020-12-01 09:58psanjuanProposed Solution updated
2020-12-01 09:58psanjuanStatusnew => acknowledged
2020-12-24 13:05vmromanosStatusacknowledged => scheduled
2020-12-24 13:05vmromanosAssigned ToTriage Finance => vmromanos
2020-12-24 13:59hgbotNote Added: 0125084
2020-12-24 14:10vmromanosNote Added: 0125085
2020-12-30 14:13hgbotResolutionopen => fixed
2020-12-30 14:13hgbotStatusscheduled => closed
2020-12-30 14:13hgbotNote Added: 0125175
2020-12-30 14:13hgbotNote Added: 0125176
2020-12-30 14:13hgbotNote Added: 0125177
2020-12-30 14:13hgbotNote Added: 0125178

Notes
(0125084)
hgbot   
2020-12-24 13:59   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/16 [^]
(0125085)
vmromanos   
2020-12-24 14:10   
Test plan:

In an environment where the french certification module is properly installed and configured.
Create some tickets, and reprint some of them.
Wait one day (this is necessary because the archiving process can be run only for past days)
In the backend, go to Archiving Process window and select a date range including yesterday. Press Done.
Open the Archiving Log window and search for the created record.
Go to Attachments section and download the ZIP file.
Uncompress it and open the files:
- OBCFR_Ticket.csv
- OBCFR_TicketReprint.csv

Make sure the column JSON is properly filled for every record.
 
Now open any of the other files that don't have a JSON column, like OBCFR_TicketTax.csv, and make sure it contains information.


Test must be run in both PostgreSQL and Oracle databases
(0125175)
hgbot   
2020-12-30 14:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: ecdc416b623ba933e22d002520cdb4e6e615fe1e
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-12-24T13:19:54+01:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/ecdc416b623ba933e22d002520cdb4e6e615fe1e [^]

Fixed ISSUE-45528: Create a copy of opencsv ResultSetHelperService class

This class is in charge of running the transformations between db types to Strings.
We need it as a way to extend for BLOB support in the future.

---
A src/org/openbravo/certification/france/archiving/ResultSetHelperService.java
---
(0125176)
hgbot   
2020-12-30 14:13   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/16 [^]
(0125177)
hgbot   
2020-12-30 14:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: ccdfbfd7c59843669aa16b714b4eaab8f0969c76
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-12-24T13:53:58+01:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/ccdfbfd7c59843669aa16b714b4eaab8f0969c76 [^]

Fixed ISSUE-45528: Adapted ResultSetHelperService to work with BLOB

CSVWriter now uses our custom BlobReadyResultSetHelperService.
This ensures both ticket and ticket print json files are properly exported.

---
A src/org/openbravo/certification/france/archiving/BlobReadyResultSetHelperService.java
M src/org/openbravo/certification/france/archiving/CsvFilesGenerator.java
---
(0125178)
hgbot   
2020-12-30 14:13   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: 60aaee32c1543bcab32f45546215e618299cfcb9
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-12-24T13:54:08+01:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/60aaee32c1543bcab32f45546215e618299cfcb9 [^]

Fixed ISSUE-45528: Added Oracle support to BlobReadyResultSetHelperService

---
M src/org/openbravo/certification/france/archiving/BlobReadyResultSetHelperService.java
---