Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045522Retail ModulesDiscounts and Promotionspublic2020-11-27 11:202022-03-02 12:40
Reporterrafaroda 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045522: 10.000 hardcoded limitation on records evaluated by the Promo Engine
Description10.000 hardcoded limitation on records evaluated by the Promo Engine

How to overcome it?
Steps To ReproduceHave a Discount and Promotion of any type

For instance, in the Product tab, add 12.000 products

The WebPOS DiscountFilterByProduct local database IndexedDB table you will have the 12.000 products

But the Promo engine will only evaluate 10.000 of them: meaning if some of the products is in the 2.000 not evaluated you will not have the promo applied when that product is added to the ticket
Proposed SolutionBeing able to configure in backend the 10.000 limit and adjust it depending on the PC hardware processing capabilities
Additional Information
TagsNOR, Performance
Relationships
related to defect 0047475 closed prakashmurugesan88 In 21Q2, some promotions are not applied when a lot of promotions are configured 
related to defect 0047502 closed ranjith_qualiantech_com Updating to 21Q2, it is required to configure the preference 'Discounts cache size' 
related to defect 0048708 closed elara 10.000 hardcoded limitation on records evaluated by the Tax Engine 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-11-27 11:20rafarodaNew Issue
2020-11-27 11:20rafarodaAssigned To => Retail
2020-11-27 11:20rafarodaResolution time => 1607554800
2020-11-27 11:20rafarodaTriggers an Emergency Pack => No
2020-11-27 11:20rafarodaTag Attached: NOR
2020-11-27 11:20rafarodaTag Attached: Performance
2020-12-04 06:36prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-12-07 09:13prakashmurugesan88Statusnew => scheduled
2020-12-08 07:56hgbotNote Added: 0124723
2020-12-08 07:56hgbotNote Added: 0124724
2020-12-08 07:57hgbotNote Added: 0124725
2020-12-10 11:18prakashmurugesan88Note Deleted: 0124723
2020-12-10 13:14hgbotNote Added: 0124757
2020-12-10 13:14hgbotResolutionopen => fixed
2020-12-10 13:14hgbotStatusscheduled => closed
2020-12-10 13:14hgbotFixed in Version => RR21Q1
2020-12-10 13:14hgbotNote Added: 0124758
2020-12-10 13:14hgbotNote Added: 0124759
2020-12-10 13:14hgbotNote Added: 0124760
2021-08-03 11:10adrianromeroRelationship addedrelated to 0047475
2021-08-26 06:48ranjith_qualiantech_comRelationship addedrelated to 0047502
2022-03-02 12:40aferrazIssue cloned0048708
2022-03-02 12:41aferrazRelationship addedrelated to 0048708

Notes
(0124724)
hgbot   
2020-12-08 07:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/202 [^]
(0124725)
hgbot   
2020-12-08 07:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/10 [^]
(0124757)
hgbot   
2020-12-10 13:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/10 [^]
(0124758)
hgbot   
2020-12-10 13:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 41a48c87727d2e3f5dc47c1b402266e74272407f
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-12-10T15:31:11+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/41a48c87727d2e3f5dc47c1b402266e74272407f [^]

Fixed BUG-45522: Changed hardcoded criteria limit to be based on preference(Discounts cache size)

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0124759)
hgbot   
2020-12-10 13:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: dab71a8710a5f682943fb84c42c53a41a22958aa
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-12-10T15:33:41+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/dab71a8710a5f682943fb84c42c53a41a22958aa [^]

Related to BUG-45522: Added new preference(Discounts cache size) to fix hardcoded criteria limit in discounts

---
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0124760)
hgbot   
2020-12-10 13:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/202 [^]