Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045518Retail ModulesWeb POSpublic2020-11-26 17:592020-12-16 22:52
Reporterngarcia 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045518: For netting payment of a Cancel Layaway the payment method and financial account of a different terminal is used
DescriptionFor netting payment of a Cancel Layaway the payment method and financial account of a different terminal is used

The query to obtain the default payment method only filters by organization and orders by obpos_app_payment_id:

select pt.fin_paymentmethod_id, p.fin_financial_account_id
from obpos_app_payment p, obpos_app_payment_type pt
where p.obpos_app_payment_type_id = pt.obpos_app_payment_type_id
and p.ad_org_id = '...'
order by p.obpos_app_payment_id
Steps To ReproduceAs System Admin Role:
   Launch the following query in SQL Query Tool

select pt.fin_paymentmethod_id, p.fin_financial_account_id
from obpos_app_payment p, obpos_app_payment_type pt
where p.obpos_app_payment_type_id = pt.obpos_app_payment_type_id
and p.ad_org_id = 'D270A5AC50874F8BA67A88EE977F8E3B'

   Save the first values shown:
45A202BF44884F05B8A1BF741E2063B6 8655A7CC5C8B43CF951277F1691E42B1

They belong to Cashbook - Vall Blanca Store-VBS1037 financial account and Cash Payment Method

As group admin role:
   Go to Financial Account window, select Cashbook - Vall Blanca Store-VBS1037 financial account and remove the Cash payment method from it

   Check that financial account belongs to VBS1037 that is deactivated

Access VBS-1 touchpoint:

   Add a product to the receipt
   Layaway this receipt (menu)
   Click on total and layaway

   Open Receipt
   Select previously created layaway
   Cancel this layaway (menu)
   Done

   Check the Cancel Layaway is stuck in Errors While Importing POS Data with the following error:
      org.openbravo.base.exception.OBException: org.openbravo.base.exception.OBException: Selected payment method doesn't exist.
    at org.openbravo.erpCommon.businessUtility.CancelOrderExecutor.cancelOrder(CancelOrderExecutor.java:97)
    at org.openbravo.erpCommon.businessUtility.CancelOrderExecutor.run(CancelOrderExecutor.java:64)
    at org.openbravo.erpCommon.businessUtility.CancelAndReplaceUtils.cancelOrder(CancelAndReplaceUtils.java:150)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:558)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034812 closed asiermartirena When doing a C&R in a terminal without payment methods, an error occurs 
related to defect 0046516 closed ranjith_qualiantech_com Cancel and replace creates the netting payment for a payment method different than the original one 
related to defect 0050649pi closed ranjith_qualiantech_com Canceling a layaway is resulting in an EWI 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-11-26 17:59ngarciaNew Issue
2020-11-26 17:59ngarciaAssigned To => Retail
2020-11-26 17:59ngarciaResolution time => 1608159600
2020-11-26 17:59ngarciaTriggers an Emergency Pack => No
2020-11-26 17:59ngarciaIssue Monitored: networkb
2020-11-26 17:59ngarciaRelationship addedrelated to 0034812
2020-12-09 17:02rqueraltaAssigned ToRetail => rqueralta
2020-12-14 14:30hgbotNote Added: 0124808
2020-12-15 08:11hgbotResolutionopen => fixed
2020-12-15 08:11hgbotStatusnew => closed
2020-12-15 08:11hgbotFixed in Version => RR21Q1
2020-12-15 08:11hgbotNote Added: 0124816
2020-12-15 08:11hgbotNote Added: 0124817
2020-12-16 07:07hgbotNote Added: 0124852
2020-12-16 22:52hgbotNote Added: 0124892
2021-05-06 11:50ranjith_qualiantech_comRelationship addedrelated to 0046516
2022-10-27 09:27ranjith_qualiantech_comRelationship addedrelated to 0050649

Notes
(0124808)
hgbot   
2020-12-14 14:30   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/209 [^]
(0124816)
hgbot   
2020-12-15 08:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 336a1fcac948f2eb481716ebc3973247b764cede
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2020-12-15T07:11:23+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/336a1fcac948f2eb481716ebc3973247b764cede [^]

Fixed ISSUE-45518: Added two more filters by terminal and order payment method to The query to obtain the default payment method

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---
(0124817)
hgbot   
2020-12-15 08:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/209 [^]
(0124852)
hgbot   
2020-12-16 07:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2fab1c51c7e16f605cf08a0b024695eb20f3dda4
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2020-12-15T14:19:25-05:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2fab1c51c7e16f605cf08a0b024695eb20f3dda4 [^]

Related to ISSUE-45518: Take organization value from obposApplications.organization instead jsonorder organization to be sure that in crosstore flow we can obtain the correct payment

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---
(0124892)
hgbot   
2020-12-16 22:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 55cb0ef41d06a7deabf827d7818c5a1bd84255b9
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2020-12-16T21:51:58+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/55cb0ef41d06a7deabf827d7818c5a1bd84255b9 [^]

Related to ISSUE-45518: Payment method parameter was removed because it is not necessary to fix this issue and this change make fail one test in try-retail

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---