Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045517Retail ModulesCoupons OTFpublic2020-11-26 16:522020-12-04 13:09
aferraz 
prakashmurugesan88 
normalmajorhave not tried
closedfixed 
5
 
 
No
0045517: OBCPOTFCouponrulesPrint masterdata model not filtered by org
OBCPOTFCouponrulesPrint masterdata model not filtered by org
- Login in https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^]
- Open "OTF_5_EUR" OTF Coupons Generation Rules
- Move to Print tab and remove the record created for * org.
- Create three new records in Print tab:
  First one for * org, "English (USA)" language and "*" print title and text.
  Second one for "Vall Blanca Store" org, "English (USA)" language and "Vall Blanca Store" print title and text.
  Third one for "Vall Boí Store" org, "English (USA)" language and "Vall Boí Store" print title and text.
- Login in https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]
- Create a ticket with one unit of Bivy bag gore-tex in order to gnerate the above coupon.
  Check the printed coupon can be any of the three defined: "*", "Vall Blanca Store" or "Vall Boí Store".
Add e.$naturalOrgCriteria filter in CouponrulesPrint.getQuery().
In org.openbravo.retail.discounts.coupons.otf/js/utils.js line 567, take the OBCPOTFCouponrulesPrint that applies to current store.
NOR
Issue History
2020-11-26 16:52aferrazNew Issue
2020-11-26 16:52aferrazAssigned To => Retail
2020-11-26 16:52aferrazTriggers an Emergency Pack => No
2020-11-26 16:56aferrazSummaryCoupon printing not correct => OBCPOTFCouponrulesPrint masterdata model not filtered by org
2020-11-26 16:56aferrazDescription Updatedbug_revision_view_page.php?rev_id=21901#r21901
2020-11-26 16:56aferrazProposed Solution updated
2020-11-26 17:01aferrazFile Added: 45517.diff
2020-11-26 17:02aferrazResolution time => 1608159600
2020-11-26 17:03aferrazTag Attached: NOR
2020-11-26 17:53aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21903#r21903
2020-11-26 17:55aferrazProposed Solution updated
2020-11-26 17:55aferrazFile Deleted: 45517.diff
2020-11-27 09:13prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-11-27 14:21prakashmurugesan88Statusnew => scheduled
2020-12-04 06:24hgbotNote Added: 0124706
2020-12-04 13:09hgbotNote Added: 0124711
2020-12-04 13:09hgbotResolutionopen => fixed
2020-12-04 13:09hgbotStatusscheduled => closed
2020-12-04 13:09hgbotNote Added: 0124712

Notes
(0124706)
hgbot   
2020-12-04 06:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/5 [^]
(0124711)
hgbot   
2020-12-04 13:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/5 [^]
(0124712)
hgbot   
2020-12-04 13:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 40a5907db405e508112feb5936f25ee5a3f3fa19
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-12-02T22:22:38+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/40a5907db405e508112feb5936f25ee5a3f3fa19 [^]

Fixed BUG-45517: Fixes OBCPOTFCouponrulesPrint masterdata model to filter by org
* Included orgLevel property in OBCPOTFCouponrulesPrint model
* Filtered print with least orgLevel

---
M src/org/openbravo/retail/discounts/coupons/otf/master/CouponUtils.java
M src/org/openbravo/retail/discounts/coupons/otf/master/CouponrulesPrint.java
M src/org/openbravo/retail/discounts/coupons/otf/master/CouponrulesPrintProperties.java
M web/org.openbravo.retail.discounts.coupons.otf/js/model/CouponrulesPrint.js
M web/org.openbravo.retail.discounts.coupons.otf/js/utils.js
---