Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045513Openbravo ERPA. Platformpublic2020-11-25 18:162020-12-16 15:58
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045513: FIN_BankStatementImport class should use OBCriteria instead of string building
DescriptionIn method matchBusinessPartnerByNameTokens of this class, it uses OBQuery and requires extra steps of String formatting and String building, this should be changed to OBCriteria to avoid concatenating String parameters.
Steps To ReproduceIn description.
Proposed SolutionChange OBQuery usage in method matchBusinessPartnerByNameTokens to OBCriteria and refactor what is necessary.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-11-25 18:16cbernerNew Issue
2020-11-25 18:16cbernerAssigned To => cberner
2020-11-25 18:16cbernerModules => Core
2020-11-25 18:16cbernerTriggers an Emergency Pack => No
2020-11-25 18:17cbernerRelationship addedrelated to 0038136
2020-11-25 18:36hgbotNote Added: 0124622
2020-11-25 18:42hgbotNote Added: 0124627
2020-12-16 15:58hgbotResolutionopen => fixed
2020-12-16 15:58hgbotStatusnew => closed
2020-12-16 15:58hgbotNote Added: 0124886
2020-12-16 15:58hgbotFixed in Version => PR21Q1
2020-12-16 15:58hgbotNote Added: 0124887

Notes
(0124622)
hgbot   
2020-11-25 18:36   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/246 [^]
(0124627)
hgbot   
2020-11-25 18:42   
Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/246 [^]
(0124886)
hgbot   
2020-12-16 15:58   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/246 [^]
(0124887)
hgbot   
2020-12-16 15:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: b901921b99e266aceec3a45a2db03aa139a23bc5
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-12-16T10:56:04+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/b901921b99e266aceec3a45a2db03aa139a23bc5 [^]

Fixes ISSUE-45513: FIN_BankStatementImport class should use OBCriteria

This class should use OBCriteria instead of OBQuery + String building,
this avoids concatenating String parameters.

Query has been refactored to use OBCriteria and String building has been
removed on this part, as it is no longer necessary.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---