Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045511POS2Restaurantspublic2020-11-25 15:432021-02-03 21:34
Reportertimothee_catteeuw 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045511: 13/11 delivery - Add a menu trough by selecting "+"
DescriptionWhen we add a menu with that feature (see the screenshot) by clicking "+" :
https://drive.google.com/file/d/1tahFGwxEbdCpPEeyy3MrYR6L1e0GJEZB/view?usp=sharing [^]

That enables to add a menu, the menu is correctly copied but it consists of 2 empty products. The new menu selected doesn't contains any real products , it is necessary to select something then.

Cf a video which show the issue below :
https://drive.google.com/file/d/1BOyybZ3pGXCjlC8UBjPBMnFmyXa8rqnY/view [^]

In order to finish the sales, it is necessary to complete each copied menu.

Actually, each copied menu has to contain initial products after copying.
Steps To ReproduceDo a ticket, select a menu, copy that menu by adding itself with "+".
Check the copied menu.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0045488 closed AugustoMauch 13/11 delivery - Negative quantity 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-11-25 15:43timothee_catteeuwNew Issue
2020-11-25 15:43timothee_catteeuwAssigned To => Retail
2020-11-25 15:43timothee_catteeuwTriggers an Emergency Pack => No
2020-12-01 18:44guilleaerReview Assigned To => guilleaer
2020-12-01 18:44guilleaerNote Added: 0124678
2020-12-01 18:44guilleaerStatusnew => closed
2020-12-01 18:44guilleaerResolutionopen => unable to reproduce
2021-01-18 18:14guilleaerAssigned ToRetail => AugustoMauch
2021-01-18 18:14guilleaerStatusclosed => new
2021-01-18 18:14guilleaerResolutionunable to reproduce => open
2021-01-18 18:14guilleaerStatusnew => scheduled
2021-01-19 17:48hgbotNote Added: 0125644
2021-01-19 17:49AugustoMauchRelationship addedhas duplicate 0045488
2021-01-20 18:50hgbotResolutionopen => fixed
2021-01-20 18:50hgbotStatusscheduled => closed
2021-01-20 18:50hgbotNote Added: 0125699
2021-01-20 18:50hgbotNote Added: 0125700
2021-02-03 21:34hgbotFixed in Version => RR21Q2
2021-02-03 21:34hgbotNote Added: 0125962

Notes
(0124678)
guilleaer   
2020-12-01 18:44   
Fixed in P1.1 delivery.

It is not possible to use that popup to increase the amount for menus
(0125644)
hgbot   
2021-01-19 17:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.restaurant/-/merge_requests/56 [^]
(0125699)
hgbot   
2021-01-20 18:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.restaurant [^]
Changeset: 18c2aad5a47d7023c31cc819daa03a4368457a30
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 2021-01-20T17:50:14+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.restaurant/-/commit/18c2aad5a47d7023c31cc819daa03a4368457a30 [^]

Fixes ISSUE-45511: Popupover is not shown when clicking on a menu ticket line

Some changes have been done to ensure the initMenu action is invoked with the proper payload. On top of that,
now initMenu sets the isEditable flag to false, ensuring that the edit line popover is not shown for menu lines

---
M web-jspack/org.openbravo.retail.restaurant/src/model/ticket/actions/InitMenu.js
M web-jspack/org.openbravo.retail.restaurant/src/model/user-interface/__test__/OpenMenuWizard.test.js
M web-jspack/org.openbravo.retail.restaurant/src/model/user-interface/__test__/SelectLineHooks.test.js
M web-jspack/org.openbravo.retail.restaurant/src/model/user-interface/actions/POSTerminalFlowActionPreparation.js
M web-jspack/org.openbravo.retail.restaurant/src/model/user-interface/user-actions/AddProductHooks.js
M web-jspack/org.openbravo.retail.restaurant/src/model/user-interface/user-actions/OpenMenuWizard.js
M web-jspack/org.openbravo.retail.restaurant/src/model/user-interface/user-actions/SelectLineHooks.js
---
(0125700)
hgbot   
2021-01-20 18:50   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.restaurant/-/merge_requests/56 [^]
(0125962)
hgbot   
2021-02-03 21:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 90e659db4e5f290efabe73af1af080de1ed80a3d
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 2021-02-03T20:28:24+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/90e659db4e5f290efabe73af1af080de1ed80a3d [^]

Fixes ISSUE-45511: CountSafeBoxProcessor does not reconcile transactions in initial count

---
M src/org/openbravo/retail/posterminal/CountSafeBoxProcessor.java
---