0045469: Rounding payment should not be added if the payment is not added

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045469

Retail Modules

Web POS

public

2020-11-04 17:33

2020-11-23 06:34

Reporter

martinsdan

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Ubuntu 18.04.1 LTS

Product Version

Target Version

RR20Q3.2

Fixed in Version

RR20Q3.2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045469: Rounding payment should not be added if the payment is not added

Description

If the rounding feature is configured for a payment and the payment is canceled when inserting, the rounding payment is still added.
If an OBPOS_preAddPayment adds the flag cancellation to true, the original payment is not added but the rounding payment is.

Steps To Reproduce

- Create an OBPOS_preAddPayment hook that adds "args.cancellation = false" if a payment is bigger than 100.
- Add a rounding to the payment method cash
  - Go to Terminal Type | Payment Method
  - Create a new payment method marked as rounding
  - Go to the payment method cash and add a new entry in the subtab Payment Rounding
  - Activate it for sales, Rounding down and "Rounding Multiple in Sales" = 0.05
- Login to the touchpoint
- Add a product that costs 101.23
- Pay it in cash

See that the only payment added is the rounding payment with an amount of 0.03

Proposed Solution

If the flag canceled is true after running all the hooks, the respective rounding payment should be reverted.

Additional Information