0045465: Web Pos still does not apply correctly the "Ending Date" of a discount or promotion

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045465

Retail Modules

Discounts and Promotions

public

2020-11-19 16:53

2020-11-23 06:57

Reporter

AugustoMauch

Assigned To

ranjith_qualiantech_com

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR21Q1

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045465: Web Pos still does not apply correctly the "Ending Date" of a discount or promotion

Description

This issue is a continuation of https://issues.openbravo.com/view.php?id=44635 [^]

Web Pos does not apply correctly the Starting date and Ending date filters of a discount if those filters include timezone information, which has already happened in clients that don't have any customizations that affects this functionality.

For instance:
new Date(new Date('2013-06-01T00:00:00+01:00').toISOString().split('T')[0])
returns
Fri May 31 2013 02:00:00 GMT+0200 (Central European Summer Time)

This is wrong, in the backend it was defined as 2013-06-01, but now in frontend has been converted to 2013-31-05

To fix it, just remove the time part before invoking the toISOString function:

new Date(new Date('2013-06-01T00:00:00+01:00'.split('T')[0]).toISOString())
Sat Jun 01 2013 02:00:00 GMT+0200 (Central European Summer Time)"

Steps To Reproduce

Same steps as described for issue 44635 make this issue reproducible in the client production and test server.

Backend:
1. Configure a new discount, for example: Variable Discount per Total Amount
2. Set Ending Date = today.

Web POS:
1. Open a new till with date = today.
2. Add a product
3. Try to add the previous discount

Actual Result: The discount is not available.
Expected result: The discount should be available:
Ending Dat: The Date To indicates the end date of a range (inclusive)

-> If you modify the Ending date = a later day, the discount is available.

Proposed Solution

Replace

new Date(new Date(stringDate).toISOString().split('T')[0])

with

new Date(new Date(stringDate.split('T')[0]).toISOString())

Additional Information