0045445: [Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045445

Retail Modules

Discounts and Promotions

public

2020-10-28 18:00

2020-11-16 07:37

Reporter

ngarcia

Assigned To

ranjith_qualiantech_com

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

RR20Q3

Target Version

RR20Q3.2

Fixed in Version

RR20Q3.2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045445: [Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount

Description

[Save Removed Tickets] Screen get frozen when trying to delete a line with a manual discount

It is reproduced in 20Q3 but not in PI

Steps To Reproduce

In the backoffice:
   Set the Web POS Save Removed Tickets preference to Y
   Create a new record in Discounts And Promotions window:
      Organization: *
      Discount Promotion Type: User Defined Percentage
      Starting date: today
      Apply Next Discount/Promotion: Y
      Included...: All excluding defined
      Percentage: 20
      Allow to Apply in Negative Lines: Y
      Log out and log in

In the POS:
   Create a new ticket
   Add Adhesive body warmers product to it
   Add the previously created discount and Apply to all lines
   Try to delete the line and check the screen is locked (grey)

The log shows:

Uncaught dodivide(): Divide by 0
D @ BigDecimal-all-1.0.3.min.js:14
v @ BigDecimal-all-1.0.3.min.js:14
div @ 24ba54b2459bf10d1c792e3d526e56ca.js:1302
div @ 24ba54b2459bf10d1c792e3d526e56ca.js:1312
pushDiscountAndUpdate @ 24ba54b2459bf10d1c792e3d526e56ca.js:2407
addDiscount @ 24ba54b2459bf10d1c792e3d526e56ca.js:2406
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2491
executeDiscountCalculation @ 24ba54b2459bf10d1c792e3d526e56ca.js:2491
calculateDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:2383
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2363
OB.Discounts.applyDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:2363
calculateLocal @ 24ba54b2459bf10d1c792e3d526e56ca.js:5426
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:5434
callbackExecutor @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
executeHooks @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
OB.Discounts.Pos.calculateDiscounts @ 24ba54b2459bf10d1c792e3d526e56ca.js:5434
calculateReceipt @ 24ba54b2459bf10d1c792e3d526e56ca.js:2621
postDeleteLine @ 24ba54b2459bf10d1c792e3d526e56ca.js:2664
_deleteLines @ 24ba54b2459bf10d1c792e3d526e56ca.js:2682
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2684
(anonymous) @ 24ba54b2459bf10d1c792e3d526e56ca.js:2709
callbackExecutor @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
executeHooks @ 24ba54b2459bf10d1c792e3d526e56ca.js:1320
deleteLineOnceChecked @ 24ba54b2459bf10d1c792e3d526e56ca.js:2694
_deleteLine @ 24ba54b2459bf10d1c792e3d526e56ca.js:2718
_deleteLines @ 24ba54b2459bf10d1c792e3d526e56ca.js:2684

Proposed Solution

Additional Information