Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045437Openbravo ERPA. Platformpublic2020-11-12 16:012020-11-24 13:14
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045437: BaseOBObject appends parameters in hql query wrongly
DescriptionBaseOBObject appends some parameters in HQL query string incorrectly, in method getTranslation. To avoid this, OBCriteria should be used instead.
Steps To ReproduceIn description.
Proposed SolutionRefactor and use OBCriteria instead.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-11-12 16:01cbernerNew Issue
2020-11-12 16:01cbernerAssigned To => cberner
2020-11-12 16:01cbernerModules => Core
2020-11-12 16:01cbernerTriggers an Emergency Pack => No
2020-11-12 16:01cbernerRelationship addedrelated to 0038136
2020-11-12 16:04hgbotNote Added: 0124330
2020-11-24 13:14hgbotResolutionopen => fixed
2020-11-24 13:14hgbotStatusnew => closed
2020-11-24 13:14hgbotNote Added: 0124584
2020-11-24 13:14hgbotFixed in Version => PR21Q1
2020-11-24 13:14hgbotNote Added: 0124585

Notes
(0124330)
hgbot   
2020-11-12 16:04   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/229 [^]
(0124584)
hgbot   
2020-11-24 13:14   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/229 [^]
(0124585)
hgbot   
2020-11-24 13:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 77234a7a40433a981bb8bf73429ea4afa35a8284
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-11-24T11:53:31+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/77234a7a40433a981bb8bf73429ea4afa35a8284 [^]

Fixes ISSUE-45437: BaseOBObject appends parameters in hql query wrongly

Method getTranslations appends some parameters in an HQL query strings
directly, this is incorrect as per our HQL style guide.
To avoid this, it has been transformed to use OBCriteria instead.

---
M src/org/openbravo/base/structure/BaseOBObject.java
---