Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045426Retail ModulesWeb POSpublic2020-11-11 16:132020-11-18 08:14
Reporterngarcia 
Assigned Toprakashmurugesan88 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket15932
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045426: Different default value in database and in Application Dictionary for EM_OBPOS_EDITABLE_PRICE
DescriptionDifferent default value in database and in Application Dictionary for EM_OBPOS_EDITABLE_PRICE

Database (src-db/database/model/modifiedTables/M_PRODUCT.xml):
      <column name="EM_OBPOS_EDITABLE_PRICE" primaryKey="false" required="true" type="CHAR" size="1" autoIncrement="false">
        <default><![CDATA[Y]]></default>
        <onCreateDefault><![CDATA['Y']]></onCreateDefault>
      </column>

Application (src-db/database/sourcedata/AD_COLUMN.xml):
<!--2B35A72B5E7F40E0A6D83F9273980F3A--> <DEFAULTVALUE><![CDATA[N]]></DEFAULTVALUE>
Steps To ReproduceIf the product is created from the backoffice it will be created with Editable Price = 'N'

If the product is created with a different process it (such as integration from other applications) will be created with Editable Price = 'Y'
Proposed SolutionSet the same default value in both places: it should be set to "Y" to preserve previous behaviour
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0031361 closed ebecerra Add a new flag at product level to determine if a product price is editable or not 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-11-11 16:13ngarciaNew Issue
2020-11-11 16:13ngarciaAssigned To => Retail
2020-11-11 16:13ngarciaOBNetwork customer => Gold
2020-11-11 16:13ngarciaSupport ticket => 15932
2020-11-11 16:13ngarciaResolution time => 1606863600
2020-11-11 16:13ngarciaTriggers an Emergency Pack => No
2020-11-11 16:13ngarciaRelationship addedcaused by 0031361
2020-11-11 16:14ngarciaIssue Monitored: networkb
2020-11-16 06:34marvintmProposed Solution updated
2020-11-16 07:22prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-11-16 14:59prakashmurugesan88Statusnew => scheduled
2020-11-17 06:19hgbotMerge Request Status => open
2020-11-17 06:19hgbotNote Added: 0124434
2020-11-17 07:04hgbotMerge Request Statusopen => approved
2020-11-17 07:04hgbotResolutionopen => fixed
2020-11-17 07:04hgbotStatusscheduled => closed
2020-11-17 07:04hgbotNote Added: 0124439
2020-11-17 07:04hgbotFixed in Version => RR21Q1
2020-11-17 07:04hgbotNote Added: 0124440
2020-11-18 08:14hgbotNote Added: 0124461

Notes
(0124434)
hgbot   
2020-11-17 06:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/187 [^]
(0124439)
hgbot   
2020-11-17 07:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/187 [^]
(0124440)
hgbot   
2020-11-17 07:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b9fc104659ccb55bcd96cb4619fc22c06cbab638
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-17T06:04:51+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b9fc104659ccb55bcd96cb4619fc22c06cbab638 [^]

Fixed BUG-45426: Changed default value for editable price as Y

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0124461)
hgbot   
2020-11-18 08:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 98754ada26645c18419ec7dc3abd9073da5aaade
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-18T09:14:40+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/98754ada26645c18419ec7dc3abd9073da5aaade [^]

Fixed BUG-45426: Fixes error on creating giftcard with expiration date
* Expiry date sent to BO is not in proper format
* isoDate must be set to ExpiryDatem which is set in applyValue function
* Due to indexeddb-based state changes, applyValue function is not called
* Instead values are set in formData using getValue
* Fixed by setting isoDate in formData by overriding getValue function.

---
M web/org.openbravo.retail.giftcards/js/components/GCNewEntitiesExpirationDate.js
---