0045415: Skip AccessLevelTest.testADataAccessLevel also for views

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045415

Openbravo ERP

A. Platform

public

2020-11-10 22:36

2020-11-11 07:15

Reporter

shuehner

Assigned To

shuehner

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

PR20Q4

Fixed in Version

PR20Q4

Merge Request Status

Review Assigned To

alostale

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045415: Skip AccessLevelTest.testADataAccessLevel also for views

Description

the testADataAccessLevel test iterates over all entities and tries to query them to verify ad_client/ad_org values of the resulting rows.

The testcase already skips entities not being a real 'database table':
- isDataSourceBased
- isHQLBased

      if (e.isDataSourceBased() || e.isHQLBased()) {
        // The entity is not associated with a database table, so it does not apply

With the same argumentation probably entities with isView() (having underlying database view's should be skipped)

Concrete failing example:
- custom view calling a database function depending on config/masterdata setup to even work

Current output:
- org.hibernate.exception.GenericJDBCException: could not extract ResultSet
- Inside stacktrace it points to date-setup problem
Caused by: org.postgresql.util.PSQLException: ERROR: @NoConversionRate@ (MXN-$) @to@ (EUR-€) @ForDate@ '11-11-2020', @Client@ 'QA Testing' @And@ @ACCS_AD_ORG_ID_D@ 'USA'.
  Where: PL/pgSQL function c_currency_convert(numeric,character varying,character varying,timestamp without time zone,character varying,character varying,character varying) line 38 at RAISE

Apart from maybe skipping views the testcase does not help at all to point to the entity having the issue.

Attached patch skips views + adds some context (entityName) to any exception thrown while running a query.

Steps To Reproduce

Noticed in a customer/project instance (ask reporter is needed for a concrete example)

Proposed Solution

Additional Information