Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045410Openbravo ERPA. Platformpublic2020-11-10 16:462020-11-11 11:50
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045410: .gitignore file ignores lib/build in ERP wrongly
Descriptionlib/build is being ignored in ERP because of how .gitignore has been created. It should not ignore this folder.
Steps To Reproduce1. Try to add a file within lib/build directory with git add <file>.
2. It will fail and show that you may run the same command with --force option.
Proposed SolutionChange "build" in .gitignore to "/build", the latter only matches build directory on the top-most directory, while the former matches all build directories, independently where they come from.

Probably all the other directories should also change to the same style in .gitignore.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-11-10 16:46cbernerNew Issue
2020-11-10 16:46cbernerAssigned To => cberner
2020-11-10 16:46cbernerOBNetwork customer => No
2020-11-10 16:46cbernerModules => Core
2020-11-10 16:46cbernerTriggers an Emergency Pack => No
2020-11-10 16:51shuehnerIssue Monitored: shuehner
2020-11-10 17:29hgbotMerge Request Status => open
2020-11-10 17:29hgbotNote Added: 0124261
2020-11-11 11:50hgbotMerge Request Statusopen => approved
2020-11-11 11:50hgbotResolutionopen => fixed
2020-11-11 11:50hgbotStatusnew => closed
2020-11-11 11:50hgbotNote Added: 0124277
2020-11-11 11:50hgbotFixed in Version => PR21Q1
2020-11-11 11:50hgbotNote Added: 0124278

Notes
(0124261)
hgbot   
2020-11-10 17:29   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/221 [^]
(0124277)
hgbot   
2020-11-11 11:50   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/221 [^]
(0124278)
hgbot   
2020-11-11 11:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 39a0b1c7219e0fefa33133d21ce6b6add2d054c0
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-11-11T09:59:47+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/39a0b1c7219e0fefa33133d21ce6b6add2d054c0 [^]

Fixes ISSUE-45410: .gitignore file ignores lib/build when it shouldn't

lib/build having build in its name was also excluded by .gitignore
configuration. To fix this, an exception has been added to add this
directory.

---
M .gitignore
---