Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045390Retail ModulesWeb POSpublic2020-11-06 11:552020-11-16 06:52
Reporteraferraz 
Assigned Toprakashmurugesan88 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045390: Error in Count Safe Box with "CashUp - Group payments by expected amount" preference enabled
DescriptionError in Count Safe Box with "CashUp - Group payments by expected amount" preference enabled
Steps To Reproduce- Enable "CashUp - Group payments by expected amount" preference.
- Login in "" terminal.
- Click on Menu -> Count Safe Box
- Click on Next
- Error is thrown in closecash-steps.js line 60 because this.model.get('paymentExpectedList') is undefined:
Uncaught TypeError: Cannot read property 'models' of undefined -> .
Proposed Solution
Additional Information
TagsNOR
Relationships
related to defect 0045432 closed jorge-garcia Error in Count Safe Box after enable Safe Box in backend 
Attached Filespng 45390.png (174,906) 2020-11-06 11:56
https://issues.openbravo.com/file_download.php?file_id=15074&type=bug
png

patch I45390_20Q3.patch (18,166) 2020-11-13 15:11
https://issues.openbravo.com/file_download.php?file_id=15086&type=bug
patch I45390_20Q3_Fix2.patch (7,190) 2020-11-15 03:04
https://issues.openbravo.com/file_download.php?file_id=15090&type=bug
Issue History
Date ModifiedUsernameFieldChange
2020-11-06 11:55aferrazNew Issue
2020-11-06 11:55aferrazAssigned To => Retail
2020-11-06 11:55aferrazOBNetwork customer => No
2020-11-06 11:55aferrazTriggers an Emergency Pack => No
2020-11-06 11:56aferrazTag Attached: NOR
2020-11-06 11:56aferrazFile Added: 45390.png
2020-11-06 11:57aferrazOBNetwork customerNo => Gold
2020-11-06 12:00aferrazResolution time => 1606431600
2020-11-09 02:17prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-11-10 13:21prakashmurugesan88Statusnew => scheduled
2020-11-12 11:10hgbotMerge Request Status => open
2020-11-12 11:10hgbotNote Added: 0124308
2020-11-12 12:23rafarodaRelationship addedrelated to 0045432
2020-11-12 12:23rafarodaNote Added: 0124311
2020-11-13 15:11prakashmurugesan88File Added: I45390_20Q3.patch
2020-11-15 03:04prakashmurugesan88File Added: I45390_20Q3_Fix2.patch
2020-11-16 06:52hgbotMerge Request Statusopen => approved
2020-11-16 06:52hgbotResolutionopen => fixed
2020-11-16 06:52hgbotStatusscheduled => closed
2020-11-16 06:52hgbotFixed in Version => RR21Q1
2020-11-16 06:52hgbotNote Added: 0124387
2020-11-16 06:52hgbotNote Added: 0124388
2020-11-16 06:52hgbotNote Added: 0124389
2020-11-16 06:52hgbotNote Added: 0124390

Notes
(0124308)
hgbot   
2020-11-12 11:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/171 [^]
(0124311)
rafaroda   
2020-11-12 12:23   
See also related 0045432
(0124387)
hgbot   
2020-11-16 06:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3c605a9bfb13ba21b8892d3dee1c3abbceab9b43
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-16T05:52:52+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3c605a9bfb13ba21b8892d3dee1c3abbceab9b43 [^]

Fixed BUG-45390: Fixes js error on moving to 2nd step in Count Safe Box
* This is because paymentExpectedList is empty
* paymentExpectedList is created in CloseCash - initializationProcess (cashup-model.js)
* But however this CloseCash - initializationProcess method is overrided in countsafebox-model.js
* And created of paymentExpectedList, paymentEmptyList is not implemented in new method
* Fixed by adding creation of paymentExpectedList code in new method

---
M web/org.openbravo.retail.posterminal/js/closecash/model/countsafebox/countsafebox-model.js
---
(0124388)
hgbot   
2020-11-16 06:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1f90e66eb8acfe97a119839d694c39e42b9cb941
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-16T05:52:52+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1f90e66eb8acfe97a119839d694c39e42b9cb941 [^]

Related to Issue-45390: Moved paymentList creation to separate function
* Therefore it can be shared by both cashup and safe boxes models

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup/cashup-model.js
M web/org.openbravo.retail.posterminal/js/closecash/model/closecash-model.js
M web/org.openbravo.retail.posterminal/js/closecash/model/countsafebox/countsafebox-model.js
---
(0124389)
hgbot   
2020-11-16 06:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/171 [^]
(0124390)
hgbot   
2020-11-16 06:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 536f46925e90e3c79b2ce7fedbad8a24a497d766
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-16T05:52:52+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/536f46925e90e3c79b2ce7fedbad8a24a497d766 [^]

Fixed BUG-45390: Fixed try errors
* payMthds are formed in the respective initializationProcess function

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup/cashup-model.js
M web/org.openbravo.retail.posterminal/js/closecash/model/closecash-model.js
M web/org.openbravo.retail.posterminal/js/closecash/model/countsafebox/countsafebox-model.js
---