Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045378Retail ModulesWeb POSpublic2020-11-04 17:352020-11-18 12:30
rafaroda 
prakashmurugesan88 
highmajorhave not tried
closedfixed 
5
 
RR21Q1 
marvintm
No
0045378: When Sell On Credit in a Touchpoint which Touchpoint Type does NOT use simplified invoice, simplified invoice created
When Sell On Credit in a Touchpoint which Touchpoint Type does NOT use simplified invoice, simplified invoice created with simplified invoice prefix and simplified invoice document sequence of the terminal (if the prefix is null it puts null)

Doing a credit Sale / Sell On Credit always generates an invoice automatically (to update the Credit): this is OK

But when doing it in a Touchpoint which Touchpoint Type with Simplified Invoice = N, it should take the Full Invoice prefix and full invoice sequence number of the terminal
See video with explanation https://drive.google.com/file/d/1lBDPqexRjE8NruroGmaJWW0k0AMVOi0X/view?usp=sharing [^]
* Update user Carl to put a Credit Line Limit = 1000 https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=220&recordId=D5BF95FA079B4248B2CA2E2DA477D1B8 [^]
* In touchpoint type: mark Allow Pay On Credit = Y https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=D01039797B054BE69CA5770B8CFB933C&recordId=BD39916225594B32A88983899CF05F72 [^]
* This Touchpoint Type is marked as Simplified Invoice = N
* In the WebPOS, do a credit sale for user Carl: it will generate an invoice with the simplified invoice prefix and simplified invoice document sequence
* You can check it by recalling the ticket and click on Menu > Print
Should take the Full Invoice prefix and full invoice sequence number of the terminal if we are in a terminal which touchpoint type is defined as Simplified Invoice = N

NOR
related to defect 0045344 closed ranjith_qualiantech_com A new preference needs to be created for WEB POS that if disable allows to issue a Full Invoice without Customer Tax ID info. 
depends on backport 0045457RR20Q4 closed prakashmurugesan88 When Sell On Credit in a Touchpoint which Touchpoint Type does NOT use simplified invoice, simplified invoice created 
depends on backport 0045458RR20Q3.2 closed prakashmurugesan88 When Sell On Credit in a Touchpoint which Touchpoint Type does NOT use simplified invoice, simplified invoice created 
patch I45378_20Q3.patch (11,418) 2020-11-12 13:19
https://issues.openbravo.com/file_download.php?file_id=15084&type=bug
Issue History
2020-11-04 17:35rafarodaNew Issue
2020-11-04 17:35rafarodaAssigned To => Retail
2020-11-04 17:35rafarodaResolution time => 1605567600
2020-11-04 17:35rafarodaTriggers an Emergency Pack => No
2020-11-04 17:35rafarodaTag Attached: NOR
2020-11-05 09:27psanjuanNote Added: 0124180
2020-11-05 09:27psanjuanProposed Solution updated
2020-11-05 09:43psanjuanNote Edited: 0124180bug_revision_view_page.php?bugnote_id=0124180#r21865
2020-11-05 09:45psanjuanNote Edited: 0124180bug_revision_view_page.php?bugnote_id=0124180#r21866
2020-11-05 10:00rafarodaRelationship addedrelated to 0045344
2020-11-09 02:16prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-11-09 06:34prakashmurugesan88Statusnew => scheduled
2020-11-12 06:56hgbotNote Added: 0124288
2020-11-12 06:56hgbotNote Added: 0124289
2020-11-12 11:00hgbotResolutionopen => fixed
2020-11-12 11:00hgbotStatusscheduled => closed
2020-11-12 11:00hgbotFixed in Version => RR21Q1
2020-11-12 11:00hgbotNote Added: 0124304
2020-11-12 11:00hgbotNote Added: 0124305
2020-11-12 11:00hgbotNote Added: 0124306
2020-11-12 11:00hgbotNote Added: 0124307
2020-11-12 13:19prakashmurugesan88File Added: I45378_20Q3.patch
2020-11-18 12:30marvintmStatusclosed => new
2020-11-18 12:30marvintmResolutionfixed => open
2020-11-18 12:30marvintmFixed in VersionRR21Q1 =>
2020-11-18 12:30marvintmStatusnew => scheduled
2020-11-18 12:30marvintmStatusscheduled => resolved
2020-11-18 12:30marvintmFixed in Version => RR21Q1
2020-11-18 12:30marvintmResolutionopen => fixed
2020-11-18 12:30marvintmReview Assigned To => marvintm
2020-11-18 12:30marvintmStatusresolved => closed

Notes
(0124180)
psanjuan   
2020-11-05 09:27   
(edited on: 2020-11-05 09:45)
Proposed solution:

- If parameter "Generate Simplified Invoice" = No

Openbravo will always create a "Full Invoice" for that sale, if the payment option used is "Sell on Credit".

Openbravo will need to check if the customer has a Tax ID, as a Full Invoice is going to be issued.

If the customer has a tax id, the full invoice can be issued

If the customer does not have a tax id, the system needs to check the preference "WEB POS Full Invoice requires tax id":

If that preference is NO - the full invoice can be issued without a Tax ID
if that preference is YES - an error message is shown, because it is not possible to issue a Full Invoice for a customer that does not have a Tax ID.

(0124288)
hgbot   
2020-11-12 06:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/168 [^]
(0124289)
hgbot   
2020-11-12 06:56   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/53 [^]
(0124304)
hgbot   
2020-11-12 11:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 0ae55be222cefac5c1aef636cd52a660c5373259
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-11T07:16:14+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/0ae55be222cefac5c1aef636cd52a660c5373259 [^]

Fixed BUG-45378: Fixes Simplified Invoice being created with Generate Simplified Invoice flag false
* Validated in Sell On Credit that if Generate Simplified Invoice is false then Full Invoice is set

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteMultiCreditTicket.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0124305)
hgbot   
2020-11-12 11:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/168 [^]
(0124306)
hgbot   
2020-11-12 11:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: aa65a1cfdb7888bff8f9772d93435c4be3eb590e
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-11-12T06:52:23+05:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/aa65a1cfdb7888bff8f9772d93435c4be3eb590e [^]

Fixed BUG-45378: Fixed test to handle new validations in sell on credit for anonymous customer

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/certification_france/OBCFRTestBase.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/NotAnonymousCustomerVerfiyPaidOnCredit.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I37776_VerifyCreditButton.java
---
(0124307)
hgbot   
2020-11-12 11:00   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/53 [^]