Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045297ModulesFrench Fiscalpublic2020-10-23 17:062020-11-19 08:26
Reportermartinsdan 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionUbuntu 18.04.1 LTS
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0045297: It is not possible to cancel a Layaway for non returnable products even for non french clients
DescriptionIf the french localization is installed, the Unreturnable Product popup is shown even for non-French clients.
The code should not run for other clients.


module version: 1.0.101
Steps To Reproduce- Create a Layaway for a non-returnable product.
- Synch it
- Load it from the backend
- Cancel the Layaway
- Synch it

The Unreturnable product popup is shown.

This is true for other flows if the canceledorder is populated.
Proposed SolutionOnly run the createCanceledOrder function if it is a french client.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-10-23 17:06martinsdanNew Issue
2020-10-23 17:06martinsdanAssigned To => Triage Finance
2020-10-23 17:06martinsdanResolution time => 1604620800
2020-10-27 10:46dmiguelezResolution time1604620800 => 1605222000
2020-10-27 11:55aferrazAssigned ToTriage Finance => aferraz
2020-11-10 16:16vmromanosStatusnew => scheduled
2020-11-10 16:16vmromanosAssigned Toaferraz => vmromanos
2020-11-11 17:14vmromanosNote Added: 0124283
2020-11-19 08:26vmromanosNote Added: 0124506
2020-11-19 08:26vmromanosStatusscheduled => resolved
2020-11-19 08:26vmromanosResolutionopen => fixed
2020-11-19 08:26vmromanosReview Assigned To => aferraz
2020-11-19 08:26vmromanosStatusresolved => closed

Notes
(0124283)
vmromanos   
2020-11-11 17:14   
Test plan:

In POS:
Create a new ticket and add any product. Pay it.
Press Open Receipt and search for the previously created ticket.
Press Cancel and Replace
Add any new product and pay it. Verify the ticket has been successfully synchronized.

In the ERP:
Login as White Valley Group Admin
Go to POS Ticket window.
Search for the original ticket and export it. Open it and format so it's easily readable.
Verify the Ticket Tax tab show positive amounts.
Now search for the canceled ticket (ends with *R) and export it. Open it and format so it's easily readable.
Verify the Ticket Tax tab show negative amounts.

Run a diff between both json files. Verify the *R json has almost the same information as the original ticket, but the following entities are with negative sign:

GROSS
NET
TAXES.NET
TAXES.AMOUNT
LINES.GROSS
LINES.NET
LINES.QTY
LINES.TAXLINES.NET
LINES.TAXLINES.AMOUNT
(0124506)
vmromanos   
2020-11-19 08:26   
See:
https://gitlab.com/openbravo/projects/functional/ci/modules/org.openbravo.certification.france.dev/-/commit/8193a904b2012098f3047478026558eb81e678c6 [^]
https://gitlab.com/openbravo/projects/functional/ci/modules/org.openbravo.certification.france.dev/-/commit/415329fd4493c9bd106fa4fc1d626b2d76fbae72 [^]