0045283: underscore dependency in discounts business logic

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0045283

Retail Modules

Web POS

public

2020-10-22 14:42

2020-10-22 14:43

Reporter

alostale

Assigned To

Retail

Priority

normal

Severity

major

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0045283: underscore dependency in discounts business logic

Description

promotion-manual.js in org.openbravo.retail.discounts which is included in Business Logic bundle continues depending on underscore.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/blob/f3088341f91216b3f9286eac751ad37329a12d17/web/org.openbravo.retail.discounts/js/promotion-manual.js [^]

Steps To Reproduce

$ find -name "*js" -type f | xargs grep "_\."
./web/org.openbravo.retail.discounts/js/promotion-manual.js: _.each(line.get('promotions'), function(p) {
./web/org.openbravo.retail.discounts/js/promotion-manual.js: oldDiscountedLinePrice = !_.isNull(line.get('discountedLinePrice'))
./web/org.openbravo.retail.discounts/js/promotion-manual.js: _.find(args.context.get('order').get('approvedList'), function(l) {
./web/org.openbravo.retail.discounts/js/promotion-manual.js: !_.contains(discountsToCheck, promotions[p].ruleId)

Proposed Solution

Additional Information