Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045260Openbravo ERPA. Platformpublic2020-10-20 10:332020-10-20 11:40
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045260: API Change: Removed shouldAddDeprecation and boolean argument in deprecation methods
DescriptionWith the changes to generate deprecated properties and entities by default, the method shouldAddDeprecation and the boolean arguments to differentiate between adding or not the deprecation are not needed anymore and have been removed, resulting in an API change.

Removed:
Method GenerateEntitiesTask.shouldAddDeprecation()
Method ModelProvider.addHelpAndDeprecationToModel(boolean) (removed the argument, resulting in another method)
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsApproved
Relationships
caused by defect 0045029 closed cberner Generate deprecated tags for deprecated properties by default 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-10-20 10:33cbernerNew Issue
2020-10-20 10:33cbernerAssigned To => alostale
2020-10-20 10:33cbernerModules => Core
2020-10-20 10:33cbernerTriggers an Emergency Pack => No
2020-10-20 10:33cbernerRelationship addedcaused by 0045029
2020-10-20 10:34alostaleTag Attached: Approved
2020-10-20 10:34alostaleAssigned Toalostale => cberner
2020-10-20 10:39cbernerDescription Updatedbug_revision_view_page.php?rev_id=21812#r21812
2020-10-20 10:54hgbotNote Added: 0123799
2020-10-20 11:40hgbotResolutionopen => fixed
2020-10-20 11:40hgbotStatusnew => closed
2020-10-20 11:40hgbotNote Added: 0123802
2020-10-20 11:40hgbotNote Added: 0123803

Notes
(0123799)
hgbot   
2020-10-20 10:54   
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/7 [^]
(0123802)
hgbot   
2020-10-20 11:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: 88dca4c1e77ee86f3ec5da41668fd9f4b16e52db
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-10-20T10:40:32+02:00
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/88dca4c1e77ee86f3ec5da41668fd9f4b16e52db [^]

Fixes ISSUE-45260: Remove shouldAddDeprecation and deprecation method arg

Entities and properties will be deprecated by default if marked as
deprecated instead of having an optional argument to activate the
deprecation. This means those shouldAddDeprecation method is not needed anymore and an
argument to differentiate between adding or removing deprecation is also
not needed.

GenerateEntitiesTask.shouldAddDeprecation method has been removed
ModelProvider.addHelpAndDeprecationToModel method has no argument now
(previously it had a boolean)

---
M java/reference/java.japi.gz
---
(0123803)
hgbot   
2020-10-20 11:40   
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/7 [^]