Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045240Retail ModulesWeb POSpublic2020-10-19 08:482020-11-13 09:01
marvintm 
ranjith_qualiantech_com 
normalmajorhave not tried
closedfixed 
5
 
RR21Q1 
No
0045240: MultiUPC filter by multiple UPCs should work in the SEARCH component in Remote mode
When the multiUPC module is installed, currently it is possible to:
- Scan by multiple UPCs in local mode
- Scan by multiple UPCs in remote mode
- Use SEARCH to filter by multiple UPCs in local mode

However, it is not possible to:
- Use SEARCH to filter by multiple UPCs in remote mode

We need to implement this last flow.
- Enable product remote mode and install multiupc module
- Try to search by any upc code defined in the multiupc table. Realise that no product was found.
Two changes need to be implemented:
- A new HQLCriteriaProcess class must be implemented, to specify in the getHQLFilter method, the subquery to filter by the multiupc table
- In the frontend, in the extendUPCSearch.js file, in the OBPOS_PreSearchProducts hook, we need to find a way to inject an HQLCriteria to the filter, specifying the qualifier defind in the previous HQLCriteriaProcess, so that when the search request is done to the backend, the infrastructure knows that the subquery must be injected in the main product query.
No tags attached.
related to defect 0048054 closed ranjith_qualiantech_com Products with multiple UPC/EAN not found in Web POS 
Issue History
2020-10-19 08:48marvintmNew Issue
2020-10-19 08:48marvintmAssigned To => Retail
2020-10-19 08:48marvintmTriggers an Emergency Pack => No
2020-10-19 09:28ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-10-22 03:20ranjith_qualiantech_comStatusnew => scheduled
2020-10-27 06:17hgbotNote Added: 0123951
2020-10-27 06:17hgbotNote Added: 0123952
2020-10-27 06:17hgbotNote Added: 0123953
2020-10-30 09:02hgbotNote Added: 0124048
2020-10-30 09:02hgbotNote Added: 0124049
2020-10-30 09:02hgbotResolutionopen => fixed
2020-10-30 09:02hgbotStatusscheduled => closed
2020-10-30 09:02hgbotFixed in Version => RR21Q1
2020-10-30 09:02hgbotNote Added: 0124050
2020-10-30 09:02hgbotNote Added: 0124051
2020-10-30 09:02hgbotNote Added: 0124052
2020-10-30 09:02hgbotNote Added: 0124053
2020-10-30 14:40marvintmNote Added: 0124073
2020-10-30 14:40marvintmStatusclosed => new
2020-10-30 14:40marvintmResolutionfixed => open
2020-10-30 14:40marvintmFixed in VersionRR21Q1 =>
2020-11-04 10:25hgbotNote Added: 0124146
2020-11-04 11:15hgbotNote Added: 0124151
2020-11-04 11:26hgbotNote Added: 0124152
2020-11-12 12:43hgbotNote Added: 0124313
2020-11-12 12:43hgbotResolutionopen => fixed
2020-11-12 12:43hgbotStatusnew => closed
2020-11-12 12:43hgbotFixed in Version => RR21Q1
2020-11-12 12:43hgbotNote Added: 0124314
2020-11-12 12:43hgbotNote Added: 0124315
2020-11-12 12:43hgbotNote Added: 0124316
2020-11-12 12:43hgbotNote Added: 0124317
2020-11-12 12:43hgbotNote Added: 0124318
2020-11-12 12:43hgbotNote Added: 0124319
2020-11-12 12:43hgbotNote Added: 0124320
2020-11-12 12:43hgbotNote Added: 0124321
2020-11-13 08:55hgbotNote Added: 0124351
2020-11-13 09:01hgbotNote Added: 0124352
2020-11-13 09:01hgbotNote Added: 0124353
2021-12-31 06:54ranjith_qualiantech_comRelationship addedrelated to 0048054

Notes
(0123951)
hgbot   
2020-10-27 06:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/merge_requests/2 [^]
(0123952)
hgbot   
2020-10-27 06:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/92 [^]
(0123953)
hgbot   
2020-10-27 06:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/135 [^]
(0124048)
hgbot   
2020-10-30 09:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: cb237c7c1d7243edba9d1ff1004092f6cb9d66dc
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-30T08:01:42+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/cb237c7c1d7243edba9d1ff1004092f6cb9d66dc [^]

Related to ISSUE-45240: Added HQLCriteria for Product Search in Remote mode
* PackProduct should not be executed if filterCriteria for pack is false

---
A src/org/openbravo/retail/posterminal/ProductHQLCriteria.java
M src/org/openbravo/retail/posterminal/master/Product.java
---
(0124049)
hgbot   
2020-10-30 09:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/135 [^]
(0124050)
hgbot   
2020-10-30 09:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/92 [^]
(0124051)
hgbot   
2020-10-30 09:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 50deb6a610b97e3ea96ac5ce9e4e317dc4b2d757
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-30T08:01:46+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/50deb6a610b97e3ea96ac5ce9e4e317dc4b2d757 [^]

Fixed ISSUE-45240: Updated QueryBuilder to use columns in HQLCriteria
* For HQLCriteria, params may have array which contains name, value, operator, which is similar like filterCriteria

---
M src/org/openbravo/mobile/core/process/HQLCriteriaProcess.java
M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0124052)
hgbot   
2020-10-30 09:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc [^]
Changeset: 56156d5d4bb4332446d67fd0779954aeb8c41580
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-30T08:01:50+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/commit/56156d5d4bb4332446d67fd0779954aeb8c41580 [^]

Related to ISSUE-45240: Added HQLCriteria for UPC Search in Remote mode

---
A src/org/openbravo/retail/multiupc/MultiUPCHQLCriteria.java
M web/org.openbravo.retail.multiupc/js/extendUPCSearch.js
---
(0124053)
hgbot   
2020-10-30 09:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/merge_requests/2 [^]
(0124073)
marvintm   
2020-10-30 14:40   
There is currently a problem with this change, so we need to do additional adjustments
(0124146)
hgbot   
2020-11-04 10:25   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/150 [^]
(0124151)
hgbot   
2020-11-04 11:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/99 [^]
(0124152)
hgbot   
2020-11-04 11:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/merge_requests/3 [^]
(0124313)
hgbot   
2020-11-12 12:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/99 [^]
(0124314)
hgbot   
2020-11-12 12:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 531eb1f4c0a4c8f1b501987b8db3a890acd9c8dd
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 2020-11-10T08:45:39+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/531eb1f4c0a4c8f1b501987b8db3a890acd9c8dd [^]

Fixed ISSUE-45240: revert commit

This reverts commit 50deb6a610b97e3ea96ac5ce9e4e317dc4b2d757.

---
M src/org/openbravo/mobile/core/process/HQLCriteriaProcess.java
M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0124315)
hgbot   
2020-11-12 12:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9424f7fdee1376292397d798ed8fb9adc484be30
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 2020-11-12T11:41:07+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9424f7fdee1376292397d798ed8fb9adc484be30 [^]

Related to ISSUE-45240 reverts commit

This reverts commit cb237c7c1d7243edba9d1ff1004092f6cb9d66dc.

---
M src/org/openbravo/retail/posterminal/master/Product.java
R src/org/openbravo/retail/posterminal/ProductHQLCriteria.java
---
(0124316)
hgbot   
2020-11-12 12:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/150 [^]
(0124317)
hgbot   
2020-11-12 12:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: e270c6414c7ee00f94aa08c9b5934ff928d62101
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 2020-11-12T11:41:07+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/e270c6414c7ee00f94aa08c9b5934ff928d62101 [^]

related to ISSUE-45240

This reverts commit d212b383fc0e8925587300ee799bb8a6de0ca681.

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
---
(0124318)
hgbot   
2020-11-12 12:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc [^]
Changeset: 45c80fafcf70b0e8d7ee67cfe76dd803f2e5013b
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 2020-11-04T11:23:11+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/commit/45c80fafcf70b0e8d7ee67cfe76dd803f2e5013b [^]

Related to ISSUE-45240: revert commit

This reverts commit 56156d5d4bb4332446d67fd0779954aeb8c41580.

---
M web/org.openbravo.retail.multiupc/js/extendUPCSearch.js
R src/org/openbravo/retail/multiupc/MultiUPCHQLCriteria.java
---
(0124319)
hgbot   
2020-11-12 12:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc [^]
Changeset: 97392a1b8541b9e6aa1eb7431839e877276cb355
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 2020-11-04T13:53:12+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/commit/97392a1b8541b9e6aa1eb7431839e877276cb355 [^]

Fixed ISSUE-45240: MultiUPC filter should work in the SEARCH component in Remote mode

---
A web/org.openbravo.retail.multiupc/js/product.js
M src/org/openbravo/retail/multiupc/MultiUPCComponentProvider.java
---
(0124320)
hgbot   
2020-11-12 12:43   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc [^]
Changeset: 7e6ba69130a0e147752015730dc58fb7afa6653e
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 2020-11-09T11:58:56+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/commit/7e6ba69130a0e147752015730dc58fb7afa6653e [^]

related to ISSUE-45240 added related index

---
A src-db/database/model/modifiedTables/M_PRODUCT.xml
---
(0124321)
hgbot   
2020-11-12 12:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/merge_requests/3 [^]
(0124351)
hgbot   
2020-11-13 08:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/175 [^]
(0124352)
hgbot   
2020-11-13 09:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b9fbbbe7f6b66224c60402a20971db585d0da3c0
Author: Sandra Huguet <sandra.huguet@openbravo.com>
Date: 2020-11-13T08:53:42+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b9fbbbe7f6b66224c60402a20971db585d0da3c0 [^]

related to ISSUE-45240 set usesContains product as default

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
---
(0124353)
hgbot   
2020-11-13 09:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/175 [^]