Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045210Retail ModulesWeb POSpublic2020-10-08 16:262020-11-05 16:02
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket18906
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045210: With Save Removed Tickets preference active, deleted returns are saved with pos order document type instead of RFC Order type
DescriptionWith Save Removed Tickets preference active, deleted returns are saved with pos order document type instead of RFC Order type
Steps To ReproduceIn the backend:
   Set the Web POS Save Removed Tickets preference to Y and selected

In the POS:
   Create two receipts and complete them
   Create a Verified Return from one of them and complete it
   Create a Verified Return from the order but do not complete it
   Delete it

In the backoffice:
   Check the first return has RFC Order document type and it is shown in Return From Customer window. This is correct
   Check the second return has POS Order document type and it is shown in the Sales Order window. This is wrong
   (This order will have negative values in Quantity deleted field of the lines)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-10-08 16:26ngarciaNew Issue
2020-10-08 16:26ngarciaAssigned To => Retail
2020-10-08 16:26ngarciaOBNetwork customer => Gold
2020-10-08 16:26ngarciaSupport ticket => 18906
2020-10-08 16:26ngarciaResolution time => 1603926000
2020-10-08 16:26ngarciaTriggers an Emergency Pack => No
2020-10-14 10:14ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-10-14 10:14ranjith_qualiantech_comStatusnew => scheduled
2020-10-15 05:23hgbotMerge Request Status => open
2020-10-15 05:23hgbotNote Added: 0123687
2020-10-15 16:57hgbotMerge Request Statusopen => approved
2020-10-15 16:57hgbotResolutionopen => fixed
2020-10-15 16:57hgbotStatusscheduled => closed
2020-10-15 16:57hgbotNote Added: 0123721
2020-10-15 16:57hgbotFixed in Version => RR21Q1
2020-10-15 16:57hgbotNote Added: 0123722
2020-10-15 16:57hgbotNote Added: 0123723
2020-10-30 09:23marvintmNote Added: 0124054
2020-10-30 09:23marvintmStatusclosed => new
2020-10-30 09:23marvintmResolutionfixed => open
2020-10-30 09:23marvintmFixed in VersionRR21Q1 =>
2020-10-30 09:23marvintmResolution time1603926000 => 1604962800
2020-11-03 06:24ranjith_qualiantech_comStatusnew => scheduled
2020-11-03 15:18hgbotNote Added: 0124127
2020-11-05 16:02hgbotResolutionopen => fixed
2020-11-05 16:02hgbotStatusscheduled => closed
2020-11-05 16:02hgbotNote Added: 0124189
2020-11-05 16:02hgbotFixed in Version => RR21Q1
2020-11-05 16:02hgbotNote Added: 0124190

Notes
(0123687)
hgbot   
2020-10-15 05:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/127 [^]
(0123721)
hgbot   
2020-10-15 16:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/127 [^]
(0123722)
hgbot   
2020-10-15 16:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: f9bbc16a5d5442fc6a970c35d58bb0ee296abd23
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-15T14:57:12+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f9bbc16a5d5442fc6a970c35d58bb0ee296abd23 [^]

Fixed ISSUE-45210: TicketType should be updated before deleting the ticket
* With Pref. Save Removed Ticket is enabled, Order TicketType should be updated before deleting it

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
---
(0123723)
hgbot   
2020-10-15 16:57   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6739f0ce882a0089e4e92667a4261b3a3f1ef41d
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2020-10-15T14:57:12+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6739f0ce882a0089e4e92667a4261b3a3f1ef41d [^]

Related to ISSUE-45210 Remove unneeded FIXME

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
---
(0124054)
marvintm   
2020-10-30 09:23   
This fix is correct, but incomplete. We also need to take into account that it is possible to assign a different prefix/sequence to returns, and in this case, apart from changing the document type, we also need to use the returns sequence and assign a proper document number
(0124127)
hgbot   
2020-11-03 15:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/148 [^]
(0124189)
hgbot   
2020-11-05 16:02   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/148 [^]
(0124190)
hgbot   
2020-11-05 16:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7bf3b8171a359b129f7094368be5dba912856966
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-11-05T15:02:30+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7bf3b8171a359b129f7094368be5dba912856966 [^]

Fixed ISSUE-45210: DocumentNo should be generated before updating delete ticket properties
* With Pref. Save Remove ticket, when deleting ticket, documentNo should be generated before updating delete ticket properties

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
---