Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045209Retail ModulesWeb POSpublic2020-10-08 14:552020-10-08 15:05
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045209: Do not use underscore inside the checkAlreadyPaid utility function
DescriptionThe utility function checkAlreadyPaid is using underscore (specifically the reduce function), and this should be changed as underscore should not be used inside the actions or action preparations.
Steps To ReproduceCheck the checkAlreadyPaid utility function inside web/org.openbravo.retail.posterminal/app/model/business-object/ticket/AddPaymentUtils.js is using underscore is using _.reduce
Proposed SolutionReplace it by the reduce function in the array object.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-10-08 14:55marvintmNew Issue
2020-10-08 14:55marvintmAssigned To => Retail
2020-10-08 14:55marvintmTriggers an Emergency Pack => No
2020-10-08 15:02hgbotResolutionopen => fixed
2020-10-08 15:02hgbotStatusnew => resolved
2020-10-08 15:02hgbotFixed in Version => RR21Q1
2020-10-08 15:02hgbotNote Added: 0123622
2020-10-08 15:03marvintmAssigned ToRetail => marvintm
2020-10-08 15:05migueldejuanaReview Assigned To => migueldejuana
2020-10-08 15:05migueldejuanaNote Added: 0123623
2020-10-08 15:05migueldejuanaStatusresolved => closed

Notes
(0123622)
hgbot   
2020-10-08 15:02   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 181245db8d7183d6e99bd19d05302af068528d72
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2020-10-08T14:57:21+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/181245db8d7183d6e99bd19d05302af068528d72 [^]

Fixed ISSUE-45209: Replaced usage of _.reduce by the native array reduce function

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/AddPaymentUtils.js
---
(0123623)
migueldejuana   
2020-10-08 15:05   
Reviewed