Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045182Retail ModulesWeb POSpublic2020-10-02 16:252020-10-05 06:56
Reportercaristu 
Assigned Tocaristu 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045182: AddProduct action can't be executed from new UI
DescriptionWhen executing the AddProduct action from the new UI some errors are appearing because:

1) OB.UTIL.servicesFilter is not available
2) OB.OBPOSPointOfSale.StockChecker.checkLineStock is not available
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0044743 closed Retail IndexedDB - Phase 2 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-10-02 16:25caristuNew Issue
2020-10-02 16:25caristuAssigned To => Retail
2020-10-02 16:25caristuTriggers an Emergency Pack => No
2020-10-02 16:25caristuAssigned ToRetail => caristu
2020-10-02 16:25caristuRelationship addedrelated to 0044743
2020-10-02 16:32hgbotNote Added: 0123499
2020-10-05 06:28hgbotResolutionopen => fixed
2020-10-05 06:28hgbotStatusnew => closed
2020-10-05 06:28hgbotFixed in Version => RR20Q4
2020-10-05 06:28hgbotNote Added: 0123500
2020-10-05 06:28hgbotNote Added: 0123501
2020-10-05 06:56priyamFixed in VersionRR20Q4 => RR21Q1

Notes
(0123499)
hgbot   
2020-10-02 16:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/121 [^]
(0123500)
hgbot   
2020-10-05 06:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 78782a5a3807bd82142e57283cdebe5658d27577
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-10-02T16:27:31+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/78782a5a3807bd82142e57283cdebe5658d27577 [^]

Fixes ISSUE-45182: AddProduct action can't be executed from new UI

  Some of the objects referenced in AddProduct are not available in the
new UI which is preventing the action to be executed properly.

  Changes applied:

  - Now the services filter implementation is placed inside
OB.App.StandardFilters.Services which is indeed available in the new UI.
And "old" OB.UTIL.servicesFilter makes use of it.

  - In the StockChecker class if OB.OBPOSPointOfSale is not available
(when we are in new UI) then we directly return true. Note that this should
be replaced in the future with a correct implementation of the stock check.

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/service/ServicesFilter.js
M web/org.openbravo.retail.posterminal/app/model/business-logic/stock/StockChecker.js
M web/org.openbravo.retail.posterminal/js/utils/servicesUtils.js
---
(0123501)
hgbot   
2020-10-05 06:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/121 [^]