Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045153Retail ModulesDiscounts and Promotionspublic2020-09-28 15:572020-10-26 07:54
Reportercbrazier 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR20Q3 
Target VersionFixed in VersionRR21Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045153: Discount and promotion - Disabling organizations are not sent to WebPOS
DescriptionWhen disabling an organization in a discount, related WebPOS IndexedDB table is not updated and the discount is still applied
Steps To Reproduce1/ Create a promotion / Discount
2/ Add an organization
3/ Run incremental refresh
4/ Disable an organization
5/ Run incremantal refresh
Proposed Solution
Additional Information
TagsNOR
Relationships
related to defect 0044662 closed ranjith_qualiantech_com Discounts are not updated on webpos after incremental refresh 
related to defect 0045154 closed ranjith_qualiantech_com Discount and promotion - Filter change are not sent to WebPOS 
related to defect 0045155 closed Retail Discount and promotion- Removing filters are not sent to WebPOS 
related to defect 0045188 closed ranjith_qualiantech_com Incremental Refresh fail: continues the load when it should stop 
related to defect 0047288 closed ranjith_qualiantech_com Discount and promotion - Disabling pricelist are not sent to WebPOS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-28 15:57cbrazierNew Issue
2020-09-28 15:57cbrazierAssigned To => Retail
2020-09-28 15:57cbrazierTriggers an Emergency Pack => No
2020-09-28 16:17rafarodaTag Attached: NOR
2020-09-28 16:17rafarodaRelationship addedrelated to 0044662
2020-09-28 16:18rafarodaRelationship addedrelated to 0045154
2020-09-28 16:18rafarodaRelationship addedrelated to 0045155
2020-09-28 16:20rafarodaResolution time => 1602280800
2020-09-28 16:20rafarodaPrioritynormal => urgent
2020-09-28 16:20rafarodaSeveritycritical => major
2020-09-29 07:53ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-10-01 08:02ranjith_qualiantech_comStatusnew => scheduled
2020-10-01 12:58hgbotNote Added: 0123479
2020-10-05 11:42rafarodaRelationship addedrelated to 0045188
2020-10-08 06:57hgbotNote Added: 0123609
2020-10-09 08:33hgbotNote Added: 0123643
2020-10-09 08:33hgbotNote Added: 0123644
2020-10-09 08:34marvintmStatusscheduled => resolved
2020-10-09 08:34marvintmFixed in Version => RR21Q1
2020-10-09 08:34marvintmResolutionopen => fixed
2020-10-09 08:34marvintmReview Assigned To => marvintm
2020-10-09 08:34marvintmStatusresolved => closed
2020-10-12 12:36hgbotNote Added: 0123662
2020-10-20 10:32hgbotNote Added: 0123797
2020-10-20 10:32hgbotNote Added: 0123798
2020-10-22 02:50hgbotNote Added: 0123829
2020-10-22 16:33rafarodaNote Added: 0123880
2020-10-22 16:33rafarodaStatusclosed => new
2020-10-22 16:33rafarodaResolutionfixed => open
2020-10-22 16:33rafarodaFixed in VersionRR21Q1 =>
2020-10-26 06:04ranjith_qualiantech_comStatusnew => scheduled
2020-10-26 06:07hgbotNote Added: 0123911
2020-10-26 07:54hgbotNote Added: 0123932
2020-10-26 07:54hgbotResolutionopen => fixed
2020-10-26 07:54hgbotStatusscheduled => closed
2020-10-26 07:54hgbotFixed in Version => RR21Q1
2020-10-26 07:54hgbotNote Added: 0123933
2021-06-29 16:43guillermogilRelationship addedrelated to 0047288

Notes
(0123479)
hgbot   
2020-10-01 12:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/8 [^]
(0123609)
hgbot   
2020-10-08 06:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/124 [^]
(0123643)
hgbot   
2020-10-09 08:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: e5ccc5d7bf5102fe5423c1cafef3a90c529d3593
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-09T06:33:22+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/e5ccc5d7bf5102fe5423c1cafef3a90c529d3593 [^]

Related to ISSUE-45153: Added Properties for Discount Master data

---
A src/org/openbravo/retail/posterminal/master/DiscountProperties.java
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0123644)
hgbot   
2020-10-09 08:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/124 [^]
(0123662)
hgbot   
2020-10-12 12:36   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings [^]
Changeset: be9e0cc488ed8d46e7d07b6a9e32b1891d9e3709
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-12T16:06:20+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.magento.mappings/-/commit/be9e0cc488ed8d46e7d07b6a9e32b1891d9e3709 [^]

Related to ISSUE-45153: Added timestamp to Discount Test Data

---
M src-test/org/openbravo/service/integration/magento/mappings/outbound/discounts/data/00-OB.json
M src-test/org/openbravo/service/integration/magento/mappings/outbound/discounts/data/01-OB.json
M src-test/org/openbravo/service/integration/magento/mappings/outbound/discounts/data/02-OB.json
M src-test/org/openbravo/service/integration/magento/mappings/outbound/discounts/data/03-OB.json
---
(0123797)
hgbot   
2020-10-20 10:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: e82feefb5a950e3a1f48a4458f85cc9acfaee8e8
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-05T20:43:00+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/e82feefb5a950e3a1f48a4458f85cc9acfaee8e8 [^]

Fixed ISSUE-45153: Added EventHandler for Offer Organization Entity
* Offer audit should be updated when there is change in OfferOrg table, since OfferOrg is used in discount query and not as masterdata query
* Added active property with Organization Check in Discount Properties

---
A src/org/openbravo/retail/discounts/event/MOfferOrganizationEventHandler.java
A src/org/openbravo/retail/discounts/master/DiscountFilterProperties.java
---
(0123798)
hgbot   
2020-10-20 10:32   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/8 [^]
(0123829)
hgbot   
2020-10-22 02:50   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: f3088341f91216b3f9286eac751ad37329a12d17
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-22T06:18:38+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/f3088341f91216b3f9286eac751ad37329a12d17 [^]

Related to ISSUE-45153: Removed unused Logger variables
* Updatd license year in DiscountFilterProperties file

---
M src/org/openbravo/retail/discounts/event/MOfferOrganizationEventHandler.java
M src/org/openbravo/retail/discounts/master/DiscountFilterProperties.java
---
(0123880)
rafaroda   
2020-10-22 16:33   
The fix is not valid: when doign a full refresh, it brings ALL the organizations discounts without organization filter, so we have a regression.

Christophe Brazier has send the patch to Antonio.
(0123911)
hgbot   
2020-10-26 06:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/134 [^]
(0123932)
hgbot   
2020-10-26 07:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/134 [^]
(0123933)
hgbot   
2020-10-26 07:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3340ca66a2f70831f432cba81b325110785fa3df
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-23T08:39:42+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3340ca66a2f70831f432cba81b325110785fa3df [^]

Fixed ISSUE-45153: Added Discount Organization Filter in Full Refresh

---
M src/org/openbravo/retail/posterminal/master/Discount.java
---