Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045136Retail ModulesWeb POSpublic2020-09-14 11:382020-10-05 13:48
Reportergorka_gil 
Assigned Togorka_gil 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q3.2Fixed in VersionRR20Q3.2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045136: Implement pending part of support remote bp discounts
DescriptionDiscountFilterBussinessPartner supports remote through preference OBPOS_remote.discount.bp.

But it is pending to implement in the new code the requests to the backend for this code.
Steps To ReproduceTest CreateOTFWithDiscounts:
- In the last part that change to carl studson bp, it don't apply the discount that it should.
Proposed SolutionThere is a function (OB.Discounts.Pos.addDiscountsByBusinessPartnerFilter) that reads the discounts from the db and store in the discounts cache,this function should be splitted in two parts one for read from the db and other to save in the discounts cache.

Check change bp method from where it is called, and also compare with all the requests of bp to the backend from where are done, in general when requesting to the backend for the bp it is needed to request also for the bp discounts.

When we get the data of the bp discounts from the backend we needed to save it to the db, so it is needed to create a masterdata endpoint for that, and since we don't know when it will be saved, we will use the splitted previous function to add directly to the discounts cache.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0045040 closed gorka_gil Implement pending part of support remote bp discounts 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-24 22:20gorka_gilTypedefect => backport
2020-09-24 22:20gorka_gilTarget Version => RR20Q3.2
2020-09-28 21:33hgbotNote Added: 0123440
2020-09-28 21:42hgbotNote Added: 0123441
2020-09-28 22:14hgbotNote Added: 0123442
2020-09-29 20:55hgbotNote Added: 0123456
2020-10-05 13:47hgbotResolutionopen => fixed
2020-10-05 13:47hgbotStatusscheduled => closed
2020-10-05 13:47hgbotFixed in Version => RR20Q3.2
2020-10-05 13:47hgbotNote Added: 0123535
2020-10-05 13:47hgbotNote Added: 0123536
2020-10-05 13:47hgbotNote Added: 0123537
2020-10-05 13:47hgbotNote Added: 0123538
2020-10-05 13:47hgbotNote Added: 0123539
2020-10-05 13:47hgbotNote Added: 0123540
2020-10-05 13:47hgbotNote Added: 0123541
2020-10-05 13:47hgbotNote Added: 0123542
2020-10-05 13:47hgbotNote Added: 0123543
2020-10-05 13:47hgbotNote Added: 0123544
2020-10-05 13:48hgbotNote Added: 0123545
2020-10-05 13:48hgbotNote Added: 0123546

Notes
(0123440)
hgbot   
2020-09-28 21:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/7 [^]
(0123441)
hgbot   
2020-09-28 21:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/113 [^]
(0123442)
hgbot   
2020-09-28 22:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/79 [^]
(0123456)
hgbot   
2020-09-29 20:55   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/47 [^]
(0123535)
hgbot   
2020-10-05 13:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: f0f5157aef4484410f719670545c5aeb92e0c8c8
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-29T12:39:44+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/f0f5157aef4484410f719670545c5aeb92e0c8c8 [^]

Fixes ISSUE-45136: Fix remote bp discounts

- Split method to add the bp discounts into read masterdata and save into the cache.
- Also mantained the old method to call the both actions when bp discounts are not remote.
- Created utility function to get the bp discounts from the backend.
- Added to the load (f5 and logins) the load of the bp discounts
  - If first login after clean cache the bp is needed to read from terminal model
    instead of read from the state

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0123536)
hgbot   
2020-10-05 13:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: af76097175dc418cc69ac6359e10f7ce6f06322b
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-29T12:39:57+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/af76097175dc418cc69ac6359e10f7ce6f06322b [^]

Related to ISSUE-45136: Fix bp dis remote to not fail in offline

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0123537)
hgbot   
2020-10-05 13:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: a2036c487333af73fb4d58008cfd1afeaceb9528
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-29T13:17:06+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/a2036c487333af73fb4d58008cfd1afeaceb9528 [^]

Related to ISSUE-45136: code review

Avoid the use of old apis in the new code

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0123538)
hgbot   
2020-10-05 13:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/7 [^]
(0123539)
hgbot   
2020-10-05 13:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8ea79872fca7ad12787e01f12dce101b90afc9ec
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-28T21:53:36+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8ea79872fca7ad12787e01f12dce101b90afc9ec [^]

Related to ISSUE-45136: when changing the bp load the bp discounts if they are in remote

- re-added DiscountFilterBusinessPartner model, to allow the ob.dal.find for remote bp discounts
- call to the utility functions to load the bp from backend and adds hte cbpartners as discounts childs
  in the discounts cache

---
A web/org.openbravo.retail.posterminal/js/model/promotions.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0123540)
hgbot   
2020-10-05 13:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 86b67c751c120308e78a655b4da681d58c785ce5
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-28T22:10:09+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/86b67c751c120308e78a655b4da681d58c785ce5 [^]

Related to ISSUE-45136: fix bp dis remote to not fail in offline

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0123541)
hgbot   
2020-10-05 13:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/113 [^]
(0123542)
hgbot   
2020-10-05 13:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5002ae7d5299a302048856024dc015af13c8c505
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-28T22:10:54+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5002ae7d5299a302048856024dc015af13c8c505 [^]

Related to ISSUE-45136: code review

Avoid the use of old apis

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0123543)
hgbot   
2020-10-05 13:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: abecda3c9c1aef1093fc8d2bfbd576fe17b03e2f
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-28T22:15:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/abecda3c9c1aef1093fc8d2bfbd576fe17b03e2f [^]

Related to ISSUE-45136: fix wrappers OB.App.DAL.remoteSearch/Get in case of error

---
M web/org.openbravo.mobile.core/app/util/DAL.js
---
(0123544)
hgbot   
2020-10-05 13:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/79 [^]
(0123545)
hgbot   
2020-10-05 13:48   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/47 [^]
(0123546)
hgbot   
2020-10-05 13:48   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 59f53978a84acf7d51af9b1a5642cbc905f2fd4d
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-29T20:51:04+02:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/59f53978a84acf7d51af9b1a5642cbc905f2fd4d [^]

Related to ISSUE-45136: Some fixes on test I39831_VerifyComboFixedPriceDiscountAppliedToProductWithSamePrice

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_combo/I39831_VerifyComboFixedPriceDiscountAppliedToProductWithSamePrice.java
---