Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045123Retail ModulesDiscounts and Promotionspublic2020-09-23 12:592020-09-28 07:17
Reportersebastien_liron 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product VersionRR20Q3.1 
Target VersionRR20Q3Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045123: use of automatic promotion cause a crash if module discountmatrixmanagment is installed
Descriptionuse of automatic promotion cause a crash if module discountmatrixmanagment is installed


Steps To Reproducehave an env at 20q3 with discountmatrixmanagment module installed

configure an automatic promotion on a product ( any kind )

connect to web pos

Open a new ticket, add the auto promo product

click on checkout -> error should appear
Proposed Solutionin hookRoleDiscount.js ( in the discountmatrixmanagement module ), line 143 :
 if (
              OB.Model.Discounts.discountRules[promotion.discountType].isManual
            ) {

should be something like :

  var discRule = OB.Model.Discounts.discountRules[promotion.discountType];
 if (
      discRule && discRule.isManual
            ) {
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-23 12:59sebastien_lironNew Issue
2020-09-23 12:59sebastien_lironAssigned To => Retail
2020-09-23 12:59sebastien_lironTriggers an Emergency Pack => No
2020-09-23 15:48sebastien_lironResolution time => 1602280800
2020-09-25 11:43ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-09-27 16:51ranjith_qualiantech_comStatusnew => scheduled
2020-09-28 06:49marvintmSeveritycritical => major
2020-09-28 06:54hgbotNote Added: 0123403
2020-09-28 07:17hgbotResolutionopen => fixed
2020-09-28 07:17hgbotStatusscheduled => closed
2020-09-28 07:17hgbotNote Added: 0123406
2020-09-28 07:17hgbotNote Added: 0123407

Notes
(0123403)
hgbot   
2020-09-28 06:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/merge_requests/1 [^]
(0123406)
hgbot   
2020-09-28 07:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement [^]
Changeset: ad89d99dbd173a45be15c2e2b4935d41e899b9cd
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-09-27T21:09:21+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/commit/ad89d99dbd173a45be15c2e2b4935d41e899b9cd [^]

Fixed ISSUE-45123: Updated Validation of DiscountType in PaymentApproval Hook

---
M web/org.openbravo.retail.discounts.discountmatrixmanagement/js/hookRoleDiscounts.js
---
(0123407)
hgbot   
2020-09-28 07:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/merge_requests/1 [^]