Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045092Openbravo ERP04. Warehouse managementpublic2020-09-18 11:042020-10-16 08:42
Reportergorkaion 
Assigned Toinigo_lerga 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Web browser
ModulesCore
Support ticket17860
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045092: Not enough context information on get_stock extension point
DescriptionThere is a customer wanting to develop a extension point in the m_get_stock_param procedure when it is called from the m_inout_create procedure.

We have observed that the record id set on the call to the get stock procedure is the order_id instead of the orderline_id. This means that there is no method to identify the order line that it is being processed. You could query the lines filtering by product, but if there is more than one line with the same product it won't be possible.
Steps To ReproduceN/A
Proposed Solutionchange the record_id sent to the get_stock procedure by the c_orderline_id.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-18 11:04gorkaionNew Issue
2020-09-18 11:04gorkaionAssigned To => Triage Finance
2020-09-18 11:04gorkaionOBNetwork customer => Gold
2020-09-18 11:04gorkaionModules => Core
2020-09-18 11:04gorkaionSupport ticket => 17860
2020-09-18 11:04gorkaionResolution time => 1602194400
2020-09-18 11:04gorkaionTriggers an Emergency Pack => No
2020-09-21 11:34dmiguelezAssigned ToTriage Finance => inigo_lerga
2020-09-22 09:35inigo_lergaStatusnew => scheduled
2020-09-22 14:20hgbotMerge Request Status => open
2020-09-22 14:20hgbotNote Added: 0123290
2020-09-22 14:40inigo_lergaNote Added: 0123291
2020-09-24 09:51gorkaionNote Added: 0123334
2020-10-09 10:45hgbotMerge Request Statusopen => approved
2020-10-09 10:45hgbotNote Added: 0123650
2020-10-09 10:45hgbotResolutionopen => fixed
2020-10-09 10:45hgbotStatusscheduled => closed
2020-10-09 10:45hgbotFixed in Version => PR21Q1
2020-10-09 10:45hgbotNote Added: 0123651
2020-10-09 10:45hgbotNote Added: 0123652
2020-10-09 10:45hgbotNote Added: 0123653
2020-10-09 12:13dmiguelezNote Added: 0123656
2020-10-16 04:22hgbotNote Added: 0123727
2020-10-16 08:42hgbotNote Added: 0123731
2020-10-16 08:42hgbotNote Added: 0123732

Notes
(0123290)
hgbot   
2020-09-22 14:20   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/177 [^]
(0123291)
inigo_lerga   
2020-09-22 14:40   
--Test Plan Mantis--

As the F&B International Group Admin role in Backend:
1º- Go to Create Shipments from Orders window.
2º- Set '*' as Organization
3º- Press Search button.
4º- Select record with Document No. '1000079'
5º- Press Process button

    #You will see that the Shipment creation has successfully being completed
    via the message shown in the UI#
(0123334)
gorkaion   
2020-09-24 09:51   
Upon further review we have noticed that the no deprecated extension point in the m_get_stock_param procedure is missing some parameters that are being used in the deprecated extension point:

          AD_PINSTANCE_PARA_INSERT(p_uuid, '100', 'Priority_Warehouse_ID', v_PriorityWarehouseID, null, null, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '110', 'M_Warehouse_Rule_ID', v_warehouse_rule_id, null, null, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '120', 'TableId', v_TableID, null, null, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '130', 'AuxID', v_AuxID, null, null, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '140', 'LineNo', null, null, v_LineNo, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '150', 'M_Reservation_ID', v_reservation_id, null, null, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '160', 'Available', v_avail, null, null, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '170', 'Nettable', v_nett, null, null, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '180', 'OverIssue', v_overissue, null, null, null, null, null);
          AD_PINSTANCE_PARA_INSERT(p_uuid, '190', 'ProcessID', v_ProcessID, null, null, null, null, null);

At least the process id should be added as well to be able to have full context of the call in the extension point.
(0123650)
hgbot   
2020-10-09 10:45   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/177 [^]
(0123651)
hgbot   
2020-10-09 10:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 258dcb37ee9e7872be24c5517f61ed1c1719bb04
Author: inigo_lerga <inigo.lerga@openbravo.com>
Date: 2020-10-09T08:39:50+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/258dcb37ee9e7872be24c5517f61ed1c1719bb04 [^]

fixes BUG-45092:orderline id in place of record id

M_GET_STOCK_PARAM call is now executed with c_orderline_id
instead of record id.

---
M src-db/database/model/functions/M_INOUT_CREATE.xml
---
(0123652)
hgbot   
2020-10-09 10:45   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d6c4953f02c7290db12e09997031f58677bce150
Author: inigo_lerga <inigo.lerga@openbravo.com>
Date: 2020-10-09T08:39:50+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d6c4953f02c7290db12e09997031f58677bce150 [^]

related to ISSUE-45092: Added parameters to no depecrated extension point

---
M src-db/database/model/functions/M_GET_STOCK_PARAM.xml
---
(0123653)
hgbot   
2020-10-09 10:45   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 29f88fbef14d2b9c69b420c986fcfc4ddaf730c5
Author: inigo_lerga <inigo.lerga@openbravo.com>
Date: 2020-10-09T08:39:50+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/29f88fbef14d2b9c69b420c986fcfc4ddaf730c5 [^]

related to ISSUE-45092: Fix for addition of parameters

---
M src-db/database/model/functions/M_GET_STOCK_PARAM.xml
---
(0123656)
dmiguelez   
2020-10-09 12:13   
This issue causes an accepted functional API Changed that can be consulted from the API Changes Documentation:
http://wiki.openbravo.com/wiki/API_changes#PI [^]
(0123727)
hgbot   
2020-10-16 04:22   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/200 [^]
(0123731)
hgbot   
2020-10-16 08:42   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2fab67f777710155b8ec09e68756a1a4747d26ee
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 2020-10-16T00:45:52+05:30
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2fab67f777710155b8ec09e68756a1a4747d26ee [^]

Related To BUG-0045092: Not enough context information
on get_stock extension point

**Use AD_EP_INSTANCE_PARA_INSERT instead of
AD_PINSTANCE_PARA_INSERT when adding parameters in no
deprecated extension points.

---
M src-db/database/model/functions/M_GET_STOCK_PARAM.xml
---
(0123732)
hgbot   
2020-10-16 08:42   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/200 [^]