Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045071Retail ModulesGift cards and gift voucherspublic2020-09-16 14:302020-10-06 09:37
maite 
ranjith_qualiantech_com 
urgentmajoralways
closedfixed 
5
 
 
No
0045071: Gift Card consumed but not pointing to any sales order, when cashup asks to delete pending tickets
Cash up process will ask to delete pending tickets in case they exists. In case this pending ticket has a gift card payment added, the gift card amount will be consumed and a gift card transaction will be created without pointing to any sales order
1. Log in the terminal. Add any product. Press on Checkout and select More and Gift Card as payment method. Use available gift card and not finish the ticket
2. Lock screen (at this point is when the gift card transaction is created)
3. Log in again and run Cash up process and press "Delete all" when it asks to delete the previous ticket. Finish cashup steps
4. Access backoffice, go to Gift Card Instance window and realize that a gift card transaction has been created without sales order associated
No tags attached.
Issue History
2020-09-16 14:30maiteNew Issue
2020-09-16 14:30maiteAssigned To => Retail
2020-09-16 14:30maiteResolution time => 1602021600
2020-09-16 14:30maiteTriggers an Emergency Pack => No
2020-09-16 14:32maiteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21693#r21693
2020-09-28 06:56ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-09-28 11:11ranjith_qualiantech_comStatusnew => scheduled
2020-09-29 14:54hgbotNote Added: 0123454
2020-10-05 08:09hgbotResolutionopen => fixed
2020-10-05 08:09hgbotStatusscheduled => closed
2020-10-05 08:09hgbotNote Added: 0123518
2020-10-05 08:09hgbotNote Added: 0123519
2020-10-06 09:37hgbotNote Added: 0123569

Notes
(0123454)
hgbot   
2020-09-29 14:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/26 [^]
(0123518)
hgbot   
2020-10-05 08:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 717e092ecd248891450f765bcd5ea8c557f23fbf
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-09-29T12:46:25+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/717e092ecd248891450f765bcd5ea8c557f23fbf [^]

Fixed ISSUE-45071: GiftCard should not be deleted when reloading POS
* When reloading POS, giftcard line should not be deleted if giftcardid or transaction present in the line
* When deleting the giftcard transaction line, transaction should be cancelled in the backoffice

---
M src/org/openbravo/retail/giftcards/GCNVComponentProvider.java
M web/org.openbravo.retail.giftcards/app/model/business-object/ticket/actions/DeleteLineActionPreparations.js
M web/org.openbravo.retail.giftcards/js/hooks/checkGiftCardMandatoryFields.js
R web/org.openbravo.retail.giftcards/js/components/GiftCardCancel.js
---
(0123519)
hgbot   
2020-10-05 08:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/26 [^]
(0123569)
hgbot   
2020-10-06 09:37   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 31ec4f694bb6a6a8b8db172bba2f4cbb7b18ee65
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-10-06T07:37:01+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/31ec4f694bb6a6a8b8db172bba2f4cbb7b18ee65 [^]

Related to ISSUE-45071: Update lineId in Jest test DeleteLineActionPreparations
* LineIds should be distinct for the jest test case
---
M web-test/model/business-object/ticket/actions/DeleteLineActionPreparations.test.js
---