Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045057Retail ModulesWeb POSpublic2020-09-15 16:422020-10-16 08:37
Reporterpsanjuan 
Assigned ToRetail 
PriorityurgentSeveritymajorReproducibilityalways
StatusnewResolutionopen 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045057: Return sales do not get the correct Tax Rate if the customer has assigned a BP Tax Category
DescriptionReturn sales do not get the correct Tax Rate if the customer has assigned a BP Tax Category
Steps To ReproduceCreate a BP Tax Category and assign it to VBS Customer.
Create a new sales tax with a 0 rate for this BP Tax Category.
In Openbravo Web POS make a sale for this customer.
Verify that the new created sales tax is shown.
Complete the sale and pay it.
By using verified return menu option, select that sale to return.

Verify that the just created sales tax is not shown, as it seems it is not being filtered by BP Tax Category.
Proposed SolutionBP Tax Category should be used while calculating sales taxes in returns.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-15 16:42psanjuanNew Issue
2020-09-15 16:42psanjuanAssigned To => Retail
2020-09-15 16:42psanjuanTriggers an Emergency Pack => No
2020-09-15 17:08psanjuanNote Added: 0123073
2020-09-15 17:10psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=21686#r21686
2020-09-15 17:10psanjuanProposed Solution updated

Notes
(0123073)
psanjuan   
2020-09-15 17:08   
This is the code failing:
if (line.has('originalTaxExempt') ? line.get('originalTaxExempt') : bpIsExempt) {
  sql = sql + " and c_tax.istaxexempt = 'true'";
} else {
  sql = sql + " and c_tax.c_taxCategory_id = '" + taxCategory + "'";
  if (bpTaxCategory) {
    sql = sql + " and c_tax.c_bp_taxcategory_id = '" + bpTaxCategory + "'";
  } else {
    sql = sql + ' and c_tax.c_bp_taxcategory_id is null';
  }
}