Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045036Retail ModulesCash uppublic2020-09-11 11:262020-09-28 16:10
Reporterjavietxe 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045036: Wrong configuration allowed for Safe Boxes
DescriptionThere is not any check of the configuration of the payment methods before enabling Safe Box management, and this leads to errors, as there are some mandatory configurations for this feature.

Add a check that when enabling the Safe Box Management, the needed configuration is checked and if it is wrong, show an error.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0045221 closed ranjith_qualiantech_com [SafeBox] Count safe box with multiple Payment method raise an error 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-11 11:26javietxeNew Issue
2020-09-11 11:26javietxeAssigned To => Retail
2020-09-11 11:26javietxeOBNetwork customer => Gold
2020-09-11 11:26javietxeResolution time => 1601589600
2020-09-11 11:26javietxeTriggers an Emergency Pack => No
2020-09-21 06:55ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-09-28 06:53ranjith_qualiantech_comStatusnew => scheduled
2020-09-28 06:54hgbotMerge Request Status => open
2020-09-28 06:54hgbotNote Added: 0123402
2020-09-28 07:27hgbotMerge Request Statusopen => approved
2020-09-28 07:27hgbotResolutionopen => fixed
2020-09-28 07:27hgbotStatusscheduled => closed
2020-09-28 07:27hgbotFixed in Version => RR20Q4
2020-09-28 07:27hgbotNote Added: 0123413
2020-09-28 07:27hgbotNote Added: 0123414
2020-09-28 16:10hgbotNote Added: 0123432
2020-10-20 10:11ranjith_qualiantech_comRelationship addedrelated to 0045221

Notes
(0123402)
hgbot   
2020-09-28 06:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/110 [^]
(0123413)
hgbot   
2020-09-28 07:27   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 13c023f4d47a815593dd00e005ac87076bea42a2
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-09-28T05:27:53+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/13c023f4d47a815593dd00e005ac87076bea42a2 [^]

Fixed ISSUE-45036: Added Validation for Safebox Configuration
* Added Initial Validation for SafeBox config in Touchpoint Type
* Added Validation when Safebox is selected if payment method and financial account are configured

---
A src/org/openbravo/retail/posterminal/event/TerminalTypeEventHandler.java
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/InitialValidations.java
M web/org.openbravo.retail.posterminal/js/components/modalsafebox.js
---
(0123414)
hgbot   
2020-09-28 07:27   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/110 [^]
(0123432)
hgbot   
2020-09-28 16:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d87ea185e45d5dd6c8959df3dea2874c2f57b34a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-09-28T14:10:13+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d87ea185e45d5dd6c8959df3dea2874c2f57b34a [^]

Fixed ISSUE-45036: Updated Initial validation Safebox query to improve performance
* Replaced OBQuery Count with uniqueResult, since maxResult has been set as 1.
---
M src/org/openbravo/retail/posterminal/InitialValidations.java
---