Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045029Openbravo ERPA. Platformpublic2020-09-10 16:072020-10-20 11:40
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045029: Generate deprecated tags for deprecated properties by default
DescriptionCurrently deprecated annotations are not added to generated classes from AD entities and properties, unless hb.generate.deprecated.properties is set to true in Openbravo.properties.

It is intended to always generate these deprecated annotations. So those should be generated by default.
Steps To ReproduceIn description
Proposed SolutionRemove hb.generate.deprecated.properties and generate "Deprecation" tags and javadoc by default for tables/columns -> entities/properties marked as deprecated.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042664 closed cberner Openbravo ERP Deprecated properties usage should be removed in platform modules 
depends on defect 0045090 closed inigo_lerga Modules Remove usage of deprecated Brand property in AWO.OperatorLoadBalancing module 
causes defect 0045260 closed cberner Openbravo ERP API Change: Removed shouldAddDeprecation and boolean argument in deprecation methods 
causes defect 0045282 closed cberner Modules idl.variants ImportProduct makes use of deprecated Brand entity 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-10 16:07cbernerNew Issue
2020-09-10 16:07cbernerAssigned To => cberner
2020-09-10 16:07cbernerModules => Core
2020-09-10 16:07cbernerTriggers an Emergency Pack => No
2020-09-10 16:08cbernerRelationship addedrelated to 0042664
2020-09-10 16:21hgbotNote Added: 0122926
2020-09-11 12:51hgbotNote Added: 0122969
2020-09-11 12:55hgbotNote Added: 0122970
2020-09-11 12:59hgbotNote Added: 0122971
2020-09-18 10:54cbernerRelationship addeddepends on 0045090
2020-10-08 13:15hgbotNote Added: 0123621
2020-10-20 10:33cbernerRelationship addedcauses 0045260
2020-10-20 11:39hgbotResolutionopen => fixed
2020-10-20 11:39hgbotStatusnew => closed
2020-10-20 11:40hgbotFixed in Version => PR21Q1
2020-10-20 11:40hgbotNote Added: 0123800
2020-10-20 11:40hgbotNote Added: 0123801
2020-10-20 11:40hgbotNote Added: 0123805
2020-10-20 11:40hgbotNote Added: 0123806
2020-10-20 11:40hgbotNote Added: 0123808
2020-10-20 11:40hgbotNote Added: 0123809
2020-10-22 14:24cbernerRelationship addedcauses 0045282

Notes
(0122926)
hgbot   
2020-09-10 16:21   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/161 [^]
(0122969)
hgbot   
2020-09-11 12:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/-/merge_requests/1 [^]
(0122970)
hgbot   
2020-09-11 12:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl.variants/-/merge_requests/1 [^]
(0122971)
hgbot   
2020-09-11 12:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/5 [^]
(0123621)
hgbot   
2020-10-08 13:15   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.operatorloadbalancing/-/merge_requests/1 [^]
(0123800)
hgbot   
2020-10-20 11:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 54a702bdfe09efcb93f65586b0d15479c0cafd7c
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-10-20T09:39:32+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/54a702bdfe09efcb93f65586b0d15479c0cafd7c [^]

Fixes ISSUE-45029: Generate deprecation tags entities and properties by default

Deprecated entities and properties were previously generating these tags
only when hg.generate.deprecated.properties was set to true in
Openbravo.properties. Now those are generated by default.

As a side-effect, the property hg.generate.deprecated.properties has
been removed and with it some methods in GenerateEntitiesTask.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachmentUtils.java
M src-test/src/org/openbravo/test/dal/DalQueryTest.java
M src-test/src/org/openbravo/test/model/RuntimeModelTest.java
M src/org/openbravo/base/gen/GenerateEntitiesTask.java
M src/org/openbravo/base/gen/entity.ftl
M src/org/openbravo/base/model/ModelProvider.java
---
(0123801)
hgbot   
2020-10-20 11:40   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/161 [^]
(0123805)
hgbot   
2020-10-20 11:40   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^]
Changeset: 0b6064fc9fb236ae0d9c4729b081543cf97296f8
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-10-08T10:55:11+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/0b6064fc9fb236ae0d9c4729b081543cf97296f8 [^]

Related to ISSUE-45029: Suppress deprecation warnings on Brand entity usage

Brand entity generates warnings in ecj when used because it has been
deprecated. For now a SuppressWarnings has been set in place, however
Brand usage should be changed to something else, probably Product
characteristic.

finalize method in AWOv_AutomaticInvoiceFromShipmentTest class has been
renamed to tearDown to remove an eclipse warning.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehousealgorithm/printing/DefaultPrintingParameters.java
---
(0123806)
hgbot   
2020-10-20 11:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/5 [^]
(0123808)
hgbot   
2020-10-20 11:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl.variants/-/merge_requests/1 [^]
(0123809)
hgbot   
2020-10-20 11:40   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl.variants [^]
Changeset: a3ff396c4f51e767db67ce026d69af1186f6f1b5
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-09-11T14:18:36+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl.variants/-/commit/a3ff396c4f51e767db67ce026d69af1186f6f1b5 [^]

Related to ISSUE-45029: Suppress deprecation warning on Brand entity usage

Brand entity is deprecated and should be fixed changed to something
else. For now a SuppressWarning has been put in place to allow correct
execution in CI after the introduction of Entity/Property deprecation
tags by default.

---
M src/org/openbravo/idl/variants/ImportProduct.java
---