Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045015Openbravo LocalizationsLocalization Francepublic2020-09-09 15:202020-09-14 18:07
Reporterlmonreal 
Assigned Tovmromanos 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date2020-08-17
Regression introduced by commithttps://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/abf01bd806a2caeb8c55760550e18709866de167 [^]
Regression levelPre packaging ( pi )
Support ticket
OBNetwork customer
Regression introduced in release
Summary0045015: Copy Store not working with Frenc Certification
DescriptionCopy store is not working with French Certification, the process fails with the following message (see attachment):

"2020-09-09 11:11:16,781 [http-4] ERROR org.openbravo.retail.copystore.process.CopyStoreProcess - Error in copy store:ERROR: null value in column "em_obcfr_isblockchained" violates not-null constraint
Detail: Failing row contains (2731576D7AE043E6B818DA784DE33939, B90190509E9F48158896CD19690ECFC9, 4C9A1E7CD2C34F45994B5AB67F9E1C17, Y, 2020-09-09 11:11:15.678, 100, 2020-09-09 11:11:15.678, 100, 1023009, 1023009, null, null, 1023009, C2449E29DD344ACBA124CE28A317FC41, 1023009QT, scan, null, null, Y, 1023009, N, N, 498, N, null, 0, null, null, 0, 2020-07-07 10:20:46.931, 2020-06-25 17:00:15.995, 2020-06-25 15:06:26.828, 2020-07-01 15:28:51.398, N, 2020-07-07 10:22:54.645, null, 2820, 2020-07-07 10:25:04.288, 2020-07-07 10:22:40.548, 2020-07-02 15:00:46.112, 2020-07-02 19:02:47.384, 2020-06-08 16:55:59.013, 7, 1.0.6200, 1.0.6200, OpenJDK Runtime Environment (build 1.8.0_252-b09), HWM, null, null, null, N, null, 0, N, N, N, FR023009, 240000, localhost, 40001, Y)."
Steps To Reproduce1. Open a environment with French Certification
2. Launch copy store
3. See process is not completed due to error in the process
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0044785 closed vmromanos Modules Add default flag for touchpoint blockchain enable 
related to design defect 0047380 new Triage Omni OMS Openbravo ERP Copy Retail Store doesn't copy the field 'Channel - Touchpoint || Blockchain Initialized' 
Attached Filespng Copy Store Error.png (148,873) 2020-09-09 15:20
https://issues.openbravo.com/file_download.php?file_id=14950&type=bug
png

png Copy st.png (151,171) 2020-09-14 18:06
https://issues.openbravo.com/file_download.php?file_id=14964&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-09-09 15:20lmonrealNew Issue
2020-09-09 15:20lmonrealFile Added: Copy Store Error.png
2020-09-09 15:20lmonrealResolution time => 1600293600
2020-09-10 10:36vmromanosStatusnew => scheduled
2020-09-10 10:36vmromanosAssigned To => vmromanos
2020-09-10 10:37vmromanosRelationship addedcaused by 0044785
2020-09-10 10:39vmromanosRegression date => 2020-08-17
2020-09-10 10:39vmromanosRegression introduced by commit => https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/abf01bd806a2caeb8c55760550e18709866de167 [^]
2020-09-10 10:39vmromanosRegression level => Pre packaging ( pi )
2020-09-10 11:55hgbotNote Added: 0122913
2020-09-11 07:10vmromanosNote Added: 0122936
2020-09-11 07:12vmromanosNote Edited: 0122936bug_revision_view_page.php?bugnote_id=0122936#r21674
2020-09-11 13:31hgbotNote Added: 0122972
2020-09-11 13:34hgbotNote Added: 0122973
2020-09-11 13:35vmromanosNote Deleted: 0122913
2020-09-11 13:35vmromanosNote Deleted: 0122972
2020-09-11 13:35hgbotResolutionopen => fixed
2020-09-11 13:35hgbotStatusscheduled => closed
2020-09-11 13:35hgbotNote Added: 0122974
2020-09-11 13:35hgbotNote Added: 0122975
2020-09-14 10:58hgbotNote Added: 0123014
2020-09-14 18:06lmonrealFile Added: Copy st.png
2020-09-14 18:07lmonrealNote Added: 0123032
2021-07-13 11:35dmiguelezRelationship addedrelated to 0047380

Notes
(0122936)
vmromanos   
2020-09-11 07:10   
(edited on: 2020-09-11 07:12)
Test plan (to be executed in Oracle and Postgres):
In an environment with the French certification and the Copy Store module, login as the White Valley Group Admin.
Open Copy Store Parameterization window and create a new record for * organization. Make sure every field is filled with a different GL/Item
Open the Copy Retail Store window and set the fields as in the attached screenshot and press Done.
Verify the process is completed successfully.
Go to to Channel- Touchpoint window and search for any record created for the new store.
Verify the Blockchain Initialized flag is set to No for all of them.

Repeat Test plan of related issue 0044785
(0122973)
hgbot   
2020-09-11 13:34   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/13 [^]
(0122974)
hgbot   
2020-09-11 13:35   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev [^]
Changeset: 808f9cbb89f3f50ea916439de288136708b7d45f
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-09-11T11:18:57+00:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/commit/808f9cbb89f3f50ea916439de288136708b7d45f [^]

Fixed BUG-45015: Copy store support

The Copy store module does the following flow:
1. It creates a new organization NOT set as ready. This organization is not available in the organization tree yet.
2. It does the clone of other stuff.
3. It includes the organization into the tree and if finally sets as ready
See org.openbravo.retail.copystore.process.CopyStoreProcess for details.

The problem was that the OBCFR_OBPOS_APPLICATIONS_TRG trigger was trying to find the new organization's legal entity using the AD_GET_ORG_LE_BU function. Either AD_GET_ORG_LE_BU or AD_GET_ORG_LE_BU_TREENODE functions require the organization to be ready and included into the tree, which is not fulfill at the moment the trigger is executed in the Copy Store process (step #2 above).

The fix forces this new column to be 'N' when the legal entity's default flag can't be found for whatever reason.

---
M src-db/database/model/triggers/OBCFR_OBPOS_APPLICATIONS_TRG.xml
---
(0122975)
hgbot   
2020-09-11 13:35   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.certification.france.dev/-/merge_requests/13 [^]
(0123014)
hgbot   
2020-09-14 10:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: 24f3c49846d566fa1d3f51371b7f1c298e80100e
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-09-11T14:13:51+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/24f3c49846d566fa1d3f51371b7f1c298e80100e [^]

Fixed BUG-45015: Copy store support

The Copy store module does the following flow:
1. It creates a new organization NOT set as ready. This organization is not available in the organization tree yet.
2. It does the clone of other stuff.
3. It includes the organization into the tree and if finally sets as ready
See org.openbravo.retail.copystore.process.CopyStoreProcess for details.

The problem was that the OBCFR_OBPOS_APPLICATIONS_TRG trigger was trying to find the new organization's legal entity using the AD_GET_ORG_LE_BU function. Either AD_GET_ORG_LE_BU or AD_GET_ORG_LE_BU_TREENODE functions require the organization to be ready and included into the tree, which is not fulfill at the moment the trigger is executed in the Copy Store process (step #2 above).

The fix forces this new column to be 'N' when the legal entity's default flag can't be found for whatever reason.

---
M src-db/database/model/triggers/OBCFR_OBPOS_APPLICATIONS_TRG.xml
---
(0123032)
lmonreal   
2020-09-14 18:07   
Test ok