Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0045008Openbravo ERPA. Platformpublic2020-09-08 09:232020-09-08 10:25
cberner 
cberner 
normalmajorhave not tried
closedfixed 
5
 
PR20Q4 
Core
No
0045008: Modulescript CreateMissingQuartzProperties fails in CI
Modulescript fails to find and copy quartz.properties.template file in CI with the following error:

[importsampledata] 263803 [main] WARN org.openbravo.modulescript.CreateMissingQuartzProperties - Config folder not found: /srv/ci/config
[importsampledata] 263805 [main] ERROR org.openbravo.modulescript.CreateMissingQuartzProperties - Couldn't copy config/quartz.properties.template to config/quartz.properties
[importsampledata] java.nio.file.NoSuchFileException: /srv/ci/config
[importsampledata] at org.openbravo.modulescript.CreateMissingQuartzProperties.getSourcePath(CreateMissingQuartzProperties.java:71) ~[classes/:?]
[importsampledata] at org.openbravo.modulescript.CreateMissingQuartzProperties.execute(CreateMissingQuartzProperties.java:43) [classes/:?]
[importsampledata] at org.openbravo.modulescript.ModuleScript.doExecute(ModuleScript.java:42) [openbravo-core.jar:?]
[importsampledata] at org.openbravo.base.ExecutionLimitBaseProcess.preExecute(ExecutionLimitBaseProcess.java:50) [openbravo-core.jar:?]
[importsampledata] at org.openbravo.modulescript.ModuleScriptHandler.execute(ModuleScriptHandler.java:65) [openbravo-core.jar:?]
[importsampledata] at org.openbravo.ddlutils.task.ImportSampledata.doExecute(ImportSampledata.java:192) [dbsourcemanager.jar:?]
[importsampledata] at org.openbravo.ddlutils.task.BaseDatabaseTask.execute(BaseDatabaseTask.java:81) [dbsourcemanager.jar:?]
[importsampledata] at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) [ant.jar:1.10.5]
In description
Check in modulescript if user.dir is already set to main OB dir.
No tags attached.
Issue History
2020-09-08 09:23cbernerNew Issue
2020-09-08 09:23cbernerAssigned To => cberner
2020-09-08 09:23cbernerModules => Core
2020-09-08 09:23cbernerTriggers an Emergency Pack => No
2020-09-08 10:09hgbotNote Added: 0122781
2020-09-08 10:25hgbotNote Added: 0122782
2020-09-08 10:25hgbotResolutionopen => fixed
2020-09-08 10:25hgbotStatusnew => closed
2020-09-08 10:25hgbotFixed in Version => PR20Q4
2020-09-08 10:25hgbotNote Added: 0122783

Notes
(0122781)
hgbot   
2020-09-08 10:09   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/148 [^]
(0122782)
hgbot   
2020-09-08 10:25   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/148 [^]
(0122783)
hgbot   
2020-09-08 10:25   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 0277070ca3b6dcb884a5ddfe4934e16bd57521f3
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-09-08T09:51:55+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0277070ca3b6dcb884a5ddfe4934e16bd57521f3 [^]

Fixes ISSUE-45008: Fix modulescript CreateMissingQuartzProperties in CI

This modulescript was failing because it was assuming user.dir property
was always set to some directory. Now it checks previously if it's
already an OB environment, using this as main dir instead of two folders
backwards. This is relevant for CI.

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/CreateMissingQuartzProperties.class
M src-util/modulescript/src/org/openbravo/modulescript/CreateMissingQuartzProperties.java
---