Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044995Retail ModulesWeb POSpublic2020-09-04 16:282021-01-30 09:14
Reporterjarmendariz 
Assigned ToRetail 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044995: Review doPrint promise to find non-returned return points
DescriptionAs a fix of issue 0044909, we found that not returning the function after executing the resolve() callback could lead to unexpected behavior. It would be convenient to review other flows of the "PrintReceipt.prototype.doPrint" function to find out if there are other missing points to return the execution.

We have identified at least one place where "return resolve();" should be done instead of just "resolve();": https://gitlab.com/openbravo/projects/retail/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js#L212 [^]

Steps To ReproduceSee above
Proposed SolutionDo "return resolve();" instead of just "resolve();" where needed.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0044909pi closed prakashmurugesan88 XML template is printed when the cancel operation is set to true 
related to feature request 0045634 closed Retail Reimplement printing infrastructure 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-04 16:28jarmendarizNew Issue
2020-09-04 16:28jarmendarizAssigned To => jarmendariz
2020-09-04 16:28jarmendarizTriggers an Emergency Pack => No
2020-09-04 16:29jarmendarizRelationship addedrelated to 0044909
2020-09-07 08:56jarmendarizStatusnew => scheduled
2020-09-16 10:31caristuAssigned Tojarmendariz => Retail
2020-09-16 10:31caristuStatusscheduled => acknowledged
2020-09-16 10:35caristuDescription Updatedbug_revision_view_page.php?rev_id=21688#r21688
2020-09-16 10:35caristuProposed Solution updated
2020-09-16 10:36caristuStatusacknowledged => scheduled
2020-09-16 10:36caristuStatusscheduled => resolved
2020-09-16 10:36caristuResolutionopen => fixed
2020-09-16 10:36caristuStatusresolved => new
2020-09-16 10:36caristuResolutionfixed => open
2021-01-18 12:13caristuRelationship addedrelated to 0045634
2021-01-30 09:14caristuReview Assigned To => caristu
2021-01-30 09:14caristuNote Added: 0125894
2021-01-30 09:14caristuStatusnew => closed
2021-01-30 09:14caristuResolutionopen => fixed

Notes
(0125894)
caristu   
2021-01-30 09:14   
This issue does no longer apply after the print refactor project (see 0045634)