Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044986Retail ModulesWeb POSpublic2020-09-04 12:432020-09-09 16:26
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044986: Cleanup old code related to delete lines
DescriptionWith issue 0044975 we are implementing the DeleteLine action in the new state engine.

But there is still code related with the old implementation to delete lines of a ticket that is no longer used and that should be deleted.
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0044975 closed caristu Implement the DeleteLine action in the new state engine 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-04 12:43caristuNew Issue
2020-09-04 12:43caristuAssigned To => caristu
2020-09-04 12:43caristuOBNetwork customer => No
2020-09-04 12:43caristuTriggers an Emergency Pack => No
2020-09-04 12:43caristuIssue generated from0044975
2020-09-04 12:43caristuRelationship addedrelated to 0044975
2020-09-04 12:46hgbotMerge Request Status => open
2020-09-04 12:46hgbotNote Added: 0122687
2020-09-07 06:26hgbotMerge Request Statusopen => approved
2020-09-09 16:26hgbotResolutionopen => fixed
2020-09-09 16:26hgbotStatusnew => closed
2020-09-09 16:26hgbotFixed in Version => RR20Q4
2020-09-09 16:26hgbotNote Added: 0122888
2020-09-09 16:26hgbotNote Added: 0122889

Notes
(0122687)
hgbot   
2020-09-04 12:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/81 [^]
(0122888)
hgbot   
2020-09-09 16:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8b42dfddd2c379598ac723e6b81b838c65d5cfbe
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-09-09T16:26:02+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8b42dfddd2c379598ac723e6b81b838c65d5cfbe [^]

Fixes ISSUE-44986 DeleteLine cleanup

  - Removed functions no longer needed
  - Removed unused hooks

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/model/order.js
R web/org.openbravo.retail.posterminal/js/hookPostUndo_DeleteLine.js
R web/org.openbravo.retail.posterminal/js/hookPreDeleteLine.js
---
(0122889)
hgbot   
2020-09-09 16:26   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/81 [^]