Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044985Retail ModulesWeb POSpublic2020-09-04 11:302020-09-07 10:47
Reporterjarmendariz 
Assigned Tojarmendariz 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044985: Rename removePayment action to deletePayment
DescriptionThere are other actions involving removing that uses the word 'delete' instead of 'remove' (e.g. deleteLine). To remain consistent with those actions, removePayment should be renamed to deletePayment.
Steps To ReproduceSee above
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-09-04 11:30jarmendarizNew Issue
2020-09-04 11:30jarmendarizAssigned To => jarmendariz
2020-09-04 11:30jarmendarizOBNetwork customer => No
2020-09-04 11:30jarmendarizTriggers an Emergency Pack => No
2020-09-04 11:34jarmendarizStatusnew => scheduled
2020-09-04 13:21hgbotMerge Request Status => open
2020-09-04 13:21hgbotNote Added: 0122688
2020-09-07 06:21hgbotMerge Request Statusopen => approved
2020-09-07 10:41hgbotNote Added: 0122725
2020-09-07 10:42hgbotNote Added: 0122726
2020-09-07 10:47hgbotResolutionopen => fixed
2020-09-07 10:47hgbotStatusscheduled => closed
2020-09-07 10:47hgbotNote Added: 0122727
2020-09-07 10:47hgbotFixed in Version => RR20Q4
2020-09-07 10:47hgbotNote Added: 0122728
2020-09-07 10:47hgbotNote Added: 0122729
2020-09-07 10:47hgbotNote Added: 0122730
2020-09-07 10:47hgbotNote Added: 0122731
2020-09-07 10:47hgbotNote Added: 0122732

Notes
(0122688)
hgbot   
2020-09-04 13:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/82 [^]
(0122725)
hgbot   
2020-09-07 10:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate/-/merge_requests/6 [^]
(0122726)
hgbot   
2020-09-07 10:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/20 [^]
(0122727)
hgbot   
2020-09-07 10:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/82 [^]
(0122728)
hgbot   
2020-09-07 10:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8d652750ba82bcf27043475c3a8ac78dc604b6dc
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-09-07T10:44:20+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8d652750ba82bcf27043475c3a8ac78dc604b6dc [^]

Fixed ISSUE-44985: Renamed removePayment action to deletePayment

---
A web-test/model/business-object/ticket/actions/DeletePayment.test.js
A web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeletePayment.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0122729)
hgbot   
2020-09-07 10:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: e6ab8dd1e30bcc79e0d38083bdf29604b8ce8b53
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-09-06T01:54:00+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/e6ab8dd1e30bcc79e0d38083bdf29604b8ce8b53 [^]

Related to ISSUE-44985: Renamed removePayment action to deletePayment

---
M web/org.openbravo.retail.giftcards/app/model/business-object/ticket/actions/RemovePaymentActionPreparation.js
---
(0122730)
hgbot   
2020-09-07 10:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/20 [^]
(0122731)
hgbot   
2020-09-07 10:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate [^]
Changeset: b78fdf6b9baf75790a72bf349101d386ce4130f0
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2020-09-06T01:55:58+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate/-/commit/b78fdf6b9baf75790a72bf349101d386ce4130f0 [^]

Related to ISSUE-44985: Renamed removePayment action to deletePayment

---
M web/org.openbravo.retail.loyalty.burn.giftcertificate/app/model/business-object/ticket/actions/RemovePaymentActionPreparation.js
---
(0122732)
hgbot   
2020-09-07 10:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.burn.giftcertificate/-/merge_requests/6 [^]