Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044974Retail ModulesWeb POSpublic2020-09-03 12:352020-10-05 06:56
Reportersanti_lozano 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket17783
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044974: Cancel this order doesn’t close correctly the backoffice stock reservation
DescriptionAfter paying for an order on web pos with a delivery mode set for it, go to backoffice and manage a reservation for it. Then on web pos cancel this order, the reservation is not correctly closed. On Stock tab of Product (M_StorageDetail) there is still the reservation and on stock reservation window quantity is still there
Steps To Reproduce* Access to Livebuilds with modules instance, role White Valley Group
* Window Preference. Check that preference “Enable stock reservations” is enabled and also enable “Web pos enable delivery modes”
* Window Product, select Bottle 1 L. Select Home Delivery on field Delivery Mode.
* Go to Web POS and create a ticket for 1 of it, pay for it.
* On Sales Order window, select it. Select its line, click on button Manage Reservation, select the line and click on done.
* On window Stock Reservation the reservation has been created, status Completed.
* On Web POS select the order from the Menu (Open Receipt). Cancel the order (Menu > Cancel this order) and pay for it (give money back).
* On window Stock Reservation remove filters to see previous reservation. Status is closed but qty and reserved qty are 1
* Go to Product window. Tab Stock, reserved qty is still 1 here
Proposed SolutionDon't allow to "Cancel this order" from Web POS if there is a reservation for it
Additional Information
TagsNo tags attached.
Relationships
related to defect 0045025 closed prakashmurugesan88 [Cross Store] Must give role access to org 2 in order to close a reservation of an order from store 2 after cancelling it 
Attached Filespng product stock bottle.png (152,717) 2020-09-03 12:35
https://issues.openbravo.com/file_download.php?file_id=14936&type=bug
png

png stock reservation bottle.png (139,700) 2020-09-03 12:37
https://issues.openbravo.com/file_download.php?file_id=14937&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-09-03 12:35santi_lozanoNew Issue
2020-09-03 12:35santi_lozanoAssigned To => Retail
2020-09-03 12:35santi_lozanoFile Added: product stock bottle.png
2020-09-03 12:35santi_lozanoOBNetwork customer => OBPS
2020-09-03 12:35santi_lozanoSupport ticket => 17783
2020-09-03 12:35santi_lozanoResolution time => 1600898400
2020-09-03 12:35santi_lozanoTriggers an Emergency Pack => No
2020-09-03 12:37santi_lozanoFile Added: stock reservation bottle.png
2020-09-03 13:09eugeniIssue Monitored: eugeni
2020-09-14 08:28marvintmResolution time1600898400 =>
2020-09-14 08:28marvintmNote Added: 0122999
2020-09-14 08:28marvintmTypedefect => design defect
2020-09-16 12:14santi_lozanoRegression date => 2020-10-07
2020-09-16 12:14santi_lozanoNote Added: 0123106
2020-09-16 12:14santi_lozanoTypedesign defect => defect
2020-09-16 12:14santi_lozanoProposed Solution updated
2020-09-16 12:15santi_lozanoResolution time => 1602021600
2020-09-16 12:15santi_lozanoRegression date2020-10-07 =>
2020-09-16 12:16santi_lozanoProposed Solution updated
2020-09-18 13:41marvintmNote Added: 0123223
2020-09-24 07:11prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2020-09-28 04:40hgbotMerge Request Status => open
2020-09-28 04:40hgbotNote Added: 0123401
2020-09-28 07:20hgbotMerge Request Statusopen => approved
2020-09-28 07:21hgbotResolutionopen => fixed
2020-09-28 07:21hgbotStatusnew => closed
2020-09-28 07:21hgbotFixed in Version => RR20Q4
2020-09-28 07:21hgbotNote Added: 0123410
2020-09-28 07:21hgbotNote Added: 0123411
2020-09-28 07:22marvintmRelationship addedrelated to 0045025
2020-10-01 08:46hgbotNote Added: 0123472
2020-10-05 06:56priyamFixed in VersionRR20Q4 => RR21Q1

Notes
(0122999)
marvintm   
2020-09-14 08:28   
I've changed this issue to design defect. Unfortunately, WebPOS currently doesn't support reservations, and some of its more complex business flows (like Cancel Order/Layaway or Cancel and Replace) do not take them into account correctly.
(0123106)
santi_lozano   
2020-09-16 12:14   
Changed again to type = defect. As Web POS doesn't support reservations, user shouldn't be allowed to "Cancel this order" from Web POS if there is a reservation for it
(This way we can avoid having inconsistent data on customers instances)
(0123223)
marvintm   
2020-09-18 13:41   
Ok, makes sense, I think this change we should be able to do.
(0123401)
hgbot   
2020-09-28 04:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/109 [^]
(0123410)
hgbot   
2020-09-28 07:21   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: dbdd258beaa9c434f69ec5aee497a45334e63d57
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-09-28T05:20:59+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/dbdd258beaa9c434f69ec5aee497a45334e63d57 [^]

Fixed BUG-44974 : Restricted cancel order in webpos if there is a reservation for any of the lines

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web/org.openbravo.retail.posterminal/js/components/menu.js
---
(0123411)
hgbot   
2020-09-28 07:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/109 [^]
(0123472)
hgbot   
2020-10-01 08:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 31abfe92ae79c88a44bff07189bd1e148eb950db
Author: Prakash M <prakash@qualiantech.com>
Date: 2020-10-01T12:06:34+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/31abfe92ae79c88a44bff07189bd1e148eb950db [^]

Fixed BUG-44974: Restricted cancel order in webpos if there is a reservation for any of the lines
* Included condition not to FilterOnReadableOrganization

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---