Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044937Openbravo ERPA. Platformpublic2020-08-31 13:322023-04-26 18:03
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044937: Update fileUpload library
DescriptionCurrent fileUpload library used in core (1.2.2) should be updated to the latest version available (1.4)[1]

[1] https://commons.apache.org/proper/commons-fileupload/ [^]
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045064PR20Q3.1 closed caristu Update fileUpload library 
depends on backport 0045065PR20Q2.2 closed caristu Update fileUpload library 
related to defect 0052268 closed meriem_azaf Update fileUpload library is outdated and should be updated to the latest release to use FileUploadBase#setFileCountMax 
blocks defect 0044973 closed platform Stack Update for PR20Q4 release 
causes design defect 0049374 acknowledged Triage Platform Base cannot upload a file to a location that already exists 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-31 13:32caristuNew Issue
2020-08-31 13:32caristuAssigned To => platform
2020-08-31 13:32caristuModules => Core
2020-08-31 13:32caristuTriggers an Emergency Pack => No
2020-08-31 13:32caristuAssigned Toplatform => caristu
2020-08-31 13:32caristuDescription Updatedbug_revision_view_page.php?rev_id=21576#r21576
2020-08-31 13:33caristuDescription Updatedbug_revision_view_page.php?rev_id=21577#r21577
2020-09-01 10:19hgbotNote Added: 0122501
2020-09-01 13:03hgbotNote Added: 0122506
2020-09-02 14:51shuehnerIssue Monitored: shuehner
2020-09-03 09:52caristuRelationship addedblocks 0044973
2020-09-07 11:43hgbotResolutionopen => fixed
2020-09-07 11:43hgbotStatusnew => closed
2020-09-07 11:43hgbotFixed in Version => PR20Q4
2020-09-07 11:43hgbotNote Added: 0122736
2020-09-07 11:43hgbotNote Added: 0122737
2020-09-07 11:47hgbotNote Added: 0122739
2020-09-07 11:47hgbotNote Added: 0122740
2020-09-07 11:50hgbotNote Added: 0122741
2020-09-16 10:58caristuNote Added: 0123097
2020-09-16 10:58caristuStatusclosed => new
2020-09-16 10:58caristuResolutionfixed => open
2020-09-16 10:58caristuFixed in VersionPR20Q4 =>
2020-09-16 11:01caristuStatusnew => scheduled
2020-09-16 11:01caristuStatusscheduled => resolved
2020-09-16 11:01caristuFixed in Version => PR20Q4
2020-09-16 11:01caristuFixed in SCM revision => 1cc1f00fa6db5780ba858122a87f1485d8d402e3
2020-09-16 11:01caristuResolutionopen => fixed
2020-09-16 11:01caristuReview Assigned To => alostale
2020-09-16 11:01caristuStatusresolved => closed
2022-05-23 10:33alostaleRelationship addedcauses 0049374
2023-04-26 18:03shuehnerIssue cloned0052268
2023-04-26 18:03shuehnerRelationship addedrelated to 0052268

Notes
(0122501)
hgbot   
2020-09-01 10:19   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/132 [^]
(0122506)
hgbot   
2020-09-01 13:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/3 [^]
(0122736)
hgbot   
2020-09-07 11:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 1cc1f00fa6db5780ba858122a87f1485d8d402e3
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-09-07T11:34:22+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/1cc1f00fa6db5780ba858122a87f1485d8d402e3 [^]

fixes BUG-44937: Update Apache Commons FileUpload

  Update Apache Commons FileUpload library to version 1.4. Together with
the library upgrade some minor changes are required:

  - FileItem class is no longer serializable[1]. For this reason with the
commons-fileupload update to version 1.4 we are no longer calling
"setSessionObject(String attribute, Serializable value)" with FileItem
as second argument but "setSessionObject(String attribute, Object value)"
which is deprecated.

  The problem is that with this change the session is no longer serializable
after setting into it a FileItem object. For the moment no additional
actions are going to be applied as this is only happening in
ModuleManagement window. So we are just adding a comment and the
SuppressWarnings annotation.

  - Removed unnecessary @SuppressWarnings("unchecked"). The
ServletFileUpload.parseRequest method does no longer require it as now
it is returning List<FileItem> instead of List.

  - Applied some minor code cleanup: removed commented-out code and use
a logger to log the exception.

[1] https://issues.apache.org/jira/browse/FILEUPLOAD-279 [^]

---
A lib/runtime/commons-fileupload-1.4.jar
M legal/Licensing.txt
M src-core/.classpath
M src-core/src/org/openbravo/base/VariablesBase.java
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
R lib/runtime/commons-fileupload-1.2.2.jar
---
(0122737)
hgbot   
2020-09-07 11:43   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/132 [^]
(0122739)
hgbot   
2020-09-07 11:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/3 [^]
(0122740)
hgbot   
2020-09-07 11:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore [^]
Changeset: 77801f2287cea21c5200bedb3df8d7c0a1afd044
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-09-01T13:01:27+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/77801f2287cea21c5200bedb3df8d7c0a1afd044 [^]

related to BUG-44937: Unnecessary @SuppressWarnings("unchecked")

---
M src/org/openbravo/retail/copystore/process/CopyBaseActionHandler.java
---
(0122741)
hgbot   
2020-09-07 11:50   
Repository: https://gitlab.com/openbravo/tools/platform/dependencies [^]
Changeset: dc56cff553d68109014dc9a8f0fa2db906314aa3
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-09-07T11:50:19+02:00
URL: https://gitlab.com/openbravo/tools/platform/dependencies/-/commit/dc56cff553d68109014dc9a8f0fa2db906314aa3 [^]

ISSUE-44937: update fileupload to 1.4

---
M build.gradle
---
(0123097)
caristu   
2020-09-16 10:58   
Reopened to schedule backports