Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044933Openbravo ERPA. Platformpublic2020-08-17 13:502020-08-31 11:50
Reportercberner 
Assigned Tocberner 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR20Q2.2Fixed in VersionPR20Q2.2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-10-15
Regression introduced in release3.0PR20Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/dded7dec5f17b8b1fc8f6c118af985c5274670a5 [^]
Triggers an Emergency PackNo
Summary0044933: Scheduling a process without start date or start time fails
DescriptionWhen trying to schedule or reschedule a process request without start date or start time it fails with a parse date exception.

In logs:
Couldn't create quartz trigger for process Acct Server Process
java.text.ParseException: Could not parse date
    at org.openbravo.scheduling.SchedulerTimeUtils.parse(SchedulerTimeUtils.java:81) ~[classes/:?]
Steps To Reproduce- Open Process Request
- Create new Process (e.g. Log Clean Up)
- Set to scheduled and empty Start Date or Start Time fields
- Save Process Request and try to schedule it

Check logs -> There's should be a parse date error.
Proposed SolutionIf date/time is missing, use default = now in SchedulerTimeUtils parse function.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0044827 closed cberner Scheduling a process without start date or start time fails 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-31 10:02cbernerTypedefect => backport
2020-08-31 10:02cbernerTarget Version => PR20Q2.2
2020-08-31 10:06hgbotNote Added: 0122469
2020-08-31 11:50hgbotNote Added: 0122476
2020-08-31 11:50hgbotResolutionopen => fixed
2020-08-31 11:50hgbotStatusscheduled => closed
2020-08-31 11:50hgbotFixed in Version => PR20Q2.2
2020-08-31 11:50hgbotNote Added: 0122477

Notes
(0122469)
hgbot   
2020-08-31 10:06   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/130 [^]
(0122476)
hgbot   
2020-08-31 11:50   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/130 [^]
(0122477)
hgbot   
2020-08-31 11:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: a5968298257987264d8e61e056f812bedfda647c
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-08-31T10:05:26+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/a5968298257987264d8e61e056f812bedfda647c [^]

Fixes ISSUE-44933: Allow scheduling a process without start date or time

Previously it was possible to schedule a process without start date or
time, assuming current date and current time. This was lost in a
refactor.
A new method getCurrentDateTime has been added to SchedulerTimeUtils to
get the missing part of date/time provided assuming "now" when missing.
It will return the date + time in the expected format for timestamp and
parse.

Fixes regression introduced in commit dded7dec5f17b8b1fc8f6c118af985c5274670a5

---
M src/org/openbravo/scheduling/SchedulerTimeUtils.java
M src/org/openbravo/scheduling/trigger/LaterTriggerGenerator.java
M src/org/openbravo/scheduling/trigger/ScheduledTriggerGenerator.java
---