Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044876Retail ModulesWeb POSpublic2020-08-21 13:502020-09-17 18:11
Reportermigueldejuana 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q3.1Fixed in VersionRR20Q3.1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2020-05-28
Regression introduced in releaseRR20Q3
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044876: Masterdata refresh is not working correctly in Remote mode
DescriptionMasterdata refresh (full and incremental) are currently not taking into account correctly the Remote mode settings.

The remote mode itself works correctly: when it is enabled either for business partner, or products, the WebPOS correctly takes it into account in the UI (for example disabling the BROWSE component), and the functionality itself also works according to the configuration (products and customers are searched remotely and retrieved from the backend dynamically).

However, the masterdata refresh processes do not take the setting into account correctly, and they attempt to load information for this models into the IndexedDB database, even when the configuration is enabled. This is not correct.
Steps To Reproduce- Clean cache
- Set Product remote mode preference
- Do login
- Check IndexedDB Product Store. ERROR! It has data and it shouldn't.

(the same thing happens for Business Partner remote mode)
Proposed SolutionThe remote mode configuration needs to be taken into account by the MasterdataController, so the refresh process ignores models affected by it if it is enabled, and IndexedDB stores are not created for them.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0044866 closed gorka_gil Masterdata refresh is not working correctly in Remote mode 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-24 12:07gorka_gilTypedefect => backport
2020-08-24 12:07gorka_gilTarget Version => RR20Q3.1
2020-09-14 15:59hgbotNote Added: 0123026
2020-09-14 18:37hgbotNote Added: 0123037
2020-09-14 19:32hgbotNote Added: 0123038
2020-09-14 19:39hgbotNote Added: 0123039
2020-09-14 20:08hgbotNote Added: 0123040
2020-09-14 20:15hgbotNote Added: 0123041
2020-09-17 18:09hgbotResolutionopen => fixed
2020-09-17 18:09hgbotStatusscheduled => closed
2020-09-17 18:09hgbotNote Added: 0123172
2020-09-17 18:09hgbotFixed in Version => RR20Q3.1
2020-09-17 18:09hgbotNote Added: 0123173
2020-09-17 18:09hgbotNote Added: 0123174
2020-09-17 18:09hgbotNote Added: 0123175
2020-09-17 18:09hgbotNote Added: 0123176
2020-09-17 18:09hgbotNote Added: 0123177
2020-09-17 18:09hgbotNote Added: 0123178
2020-09-17 18:09hgbotNote Added: 0123179
2020-09-17 18:09hgbotNote Added: 0123180
2020-09-17 18:09hgbotNote Added: 0123181
2020-09-17 18:09hgbotNote Added: 0123182
2020-09-17 18:10hgbotNote Added: 0123183
2020-09-17 18:10hgbotNote Added: 0123184
2020-09-17 18:10hgbotNote Added: 0123185
2020-09-17 18:10hgbotNote Added: 0123186
2020-09-17 18:10hgbotNote Added: 0123187
2020-09-17 18:10hgbotNote Added: 0123188
2020-09-17 18:11hgbotNote Added: 0123189
2020-09-17 18:11hgbotNote Added: 0123190
2020-09-17 18:11hgbotNote Added: 0123191
2020-09-17 18:11hgbotNote Added: 0123192

Notes
(0123026)
hgbot   
2020-09-14 15:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/97 [^]
(0123037)
hgbot   
2020-09-14 18:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/66 [^]
(0123038)
hgbot   
2020-09-14 19:32   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/43 [^]
(0123039)
hgbot   
2020-09-14 19:39   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/10 [^]
(0123040)
hgbot   
2020-09-14 20:08   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/24 [^]
(0123041)
hgbot   
2020-09-14 20:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.activediscountspopup/-/merge_requests/2 [^]
(0123172)
hgbot   
2020-09-17 18:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/97 [^]
(0123173)
hgbot   
2020-09-17 18:09   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 9a305c734fa7e36365997a498b3858f2d8241781
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:09:40+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/9a305c734fa7e36365997a498b3858f2d8241781 [^]

Fixed ISSUE-44876: fix masterdata refresh for remote models

---
M web/org.openbravo.retail.posterminal/app/model/masterdata/BusinessPartnerLocationModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/BusinessPartnerModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/CharacteristicModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/CharacteristicValueModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ProductCharacteristicValueModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ProductModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ProductPriceModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ProductServiceLinkedModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ServicePriceRuleModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ServicePriceRuleRangeModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ServicePriceRuleRangePricesModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ServicePriceRuleVersionModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ServiceProductCategoryModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ServiceProductModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/discount/DiscountFilterBusinessPartnerModel.js
---
(0123174)
hgbot   
2020-09-17 18:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: e41d64cbd45ddc21f725d7bec934f3dc1b266d79
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:09:40+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/e41d64cbd45ddc21f725d7bec934f3dc1b266d79 [^]

Related to ISSUE-44876: Fix change bp in mpl with remote produtcs

Changing bussiness partner in multiprice list, removes and adds
again all the ticket lines, but when adding the new lines
the remotes products were not found, so was failing to add the lines

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0123175)
hgbot   
2020-09-17 18:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 486b377edb13a744be55cd11fbe89fba6865289c
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:09:40+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/486b377edb13a744be55cd11fbe89fba6865289c [^]

Related to ISSUE-44876: Fix error when moving a quotation to sales order in remote mode

The problem was that when opening a quotation from the pos,
the products of the lines are loaded with LoadedProduct instead Product serviceRequest,
this leads to some missing properties like in this case obposEditablePrice,
that was used for the validations

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0123176)
hgbot   
2020-09-17 18:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 1e3e23b7e8896f1b4a249ca0c1b0dcac35ec4c2b
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:09:40+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/1e3e23b7e8896f1b4a249ca0c1b0dcac35ec4c2b [^]

Related to ISSUE-44876: fix overwrite of shared variable in open receipt

the iter variable gets overwrited from others for loops,
passed as parameter to addLineForProduct,
and created a function to mantain the iter for the success callback of the ob.dal.get

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0123177)
hgbot   
2020-09-17 18:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d761a312a34512e02b0dfa1a1dd701ff34761c15
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:09:40+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d761a312a34512e02b0dfa1a1dd701ff34761c15 [^]

Related to ISSUE-44876: fix in open receipt on remote mode all lines with same price

After the last fix to avoid the overwrite of iter, were missing also some variables
price, lineGross, and lineNet. Removed the properties and calculate inside
the function based on the correct iter

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0123178)
hgbot   
2020-09-17 18:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8baed4343cea89ef4c61af0ad33a7f5e7715763f
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:09:40+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8baed4343cea89ef4c61af0ad33a7f5e7715763f [^]

Related to ISSUE-44876: Fix the expand of packs with remote products

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0123179)
hgbot   
2020-09-17 18:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 6861f515ad7624b93b4a0d6cc72d82f110a725fb
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-16T20:24:46+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/6861f515ad7624b93b4a0d6cc72d82f110a725fb [^]

Related to ISSUE-44876: fix masterdata refresh for remote models

Add support for remote models in the indexeddb masterdata models

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataModel.js
---
(0123182)
hgbot   
2020-09-17 18:09   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/66 [^]
(0123181)
hgbot   
2020-09-17 18:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: a023c38e6d46b3a76afafc1402f393f7b55228ff
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-16T20:24:46+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/a023c38e6d46b3a76afafc1402f393f7b55228ff [^]

Related to ISSUE-44876: create wrapper OB.App.DAL.remoteGet

Since await ob.dal.get doesn't work, it is possible to use this wrapper
and use await OB.App.DAL.remoteGet

---
A web/org.openbravo.mobile.core/app/util/DAL.js
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
---
(0123180)
hgbot   
2020-09-17 18:09   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 14480c89da53856311eab3139b1708e35217124a
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-16T20:24:57+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/14480c89da53856311eab3139b1708e35217124a [^]

Related to ISSUE-44876: change masterdata endpoint to use the new method isRemote from the model

---
M web/org.openbravo.mobile.core/app/model/synchronization-buffer/MasterdataEndpoint.js
---
(0123183)
hgbot   
2020-09-17 18:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: 661b9087704a91cddad2acf1dd493fe336e1958c
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-14T19:40:03+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/661b9087704a91cddad2acf1dd493fe336e1958c [^]

Related to ISSUE-44876: fix get of remote product in returns

Revert removal of OB.Dal.get in product for returns

---
M web/org.openbravo.retail.returns/js/returnUtils.js
---
(0123184)
hgbot   
2020-09-17 18:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/10 [^]
(0123185)
hgbot   
2020-09-17 18:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: d3d1c899709d380589acb1b07aeda5199c896e01
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-16T20:20:04+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/d3d1c899709d380589acb1b07aeda5199c896e01 [^]

Related to ISSUE-44876: fix remote products in gift cards

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js
---
(0123186)
hgbot   
2020-09-17 18:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/24 [^]
(0123187)
hgbot   
2020-09-17 18:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.activediscountspopup [^]
Changeset: 74c71bcab22de33a1707d525220eb83122383d6c
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-16T20:17:26+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.activediscountspopup/-/commit/74c71bcab22de33a1707d525220eb83122383d6c [^]

Related to ISSUE-44876: fix active discounts popup with remote products

---
M web/org.openbravo.retail.activediscountspopup/js/active-discounts-components.js
---
(0123188)
hgbot   
2020-09-17 18:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.activediscountspopup/-/merge_requests/2 [^]
(0123189)
hgbot   
2020-09-17 18:11   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 766ea73fb4a688472a6dd30833cfc537ea6c5129
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:10:06+00:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/766ea73fb4a688472a6dd30833cfc537ea6c5129 [^]

Related to ISSUE-44876: Fix test I35931_SaveCorrectlyCustomerShipmentAndBillingInfo

There is no longermasterdata info of bp in the indexeddb tables,
and needed to check in the state

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35931_SaveCorrectlyCustomerShipmentAndBillingInfo.java
---
(0123190)
hgbot   
2020-09-17 18:11   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: f0b6358be75cf20bdb08691ebd47e97cf4733c0d
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:10:06+00:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/f0b6358be75cf20bdb08691ebd47e97cf4733c0d [^]

Related to ISSUE-44876: disable test BPSet_DiscountTest in highvol

It was enable in 20q3, but was working because by current bug (44866)
the model DiscountFilterBusinessPartner was loaded into indexedDB,
although preference OBPOS_remote.discount.bp was specified.

Now that this table is correctly not loaded in remote,
this test fail in remote (highvol) like previously to 20q3

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/BPSet_DiscountTest.java
---
(0123191)
hgbot   
2020-09-17 18:11   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/43 [^]
(0123192)
hgbot   
2020-09-17 18:11   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 431b83658ac25189b69fb68d844b3188191eae17
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2020-09-17T16:10:06+00:00
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/431b83658ac25189b69fb68d844b3188191eae17 [^]

Related to ISSUE-44876: Fix test I35931_SaveCorrectlyCustomerShipmentAndBillingInfo for 20q3

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I35931_SaveCorrectlyCustomerShipmentAndBillingInfo.java
---