Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0044860 | Retail Modules | Web POS Hardware Manager | public | 2020-08-20 15:10 | 2020-08-31 13:11 |
|
| Reporter | shuehner | |
| Assigned To | prakashmurugesan88 | |
| Priority | urgent | Severity | critical | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR20Q4 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0044860: DeviceProcessStats.java from hardwaremanager uses Base64 class from itextpdf which is not needed + not correct |
| Description | This file uses Base64 utility class from itxtpdf library
./org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/pos/monitor/DeviceProcessStats.java:import com.itextpdf.text.pdf.codec.Base64;
./org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/pos/monitor/DeviceProcessStats.java: json.put("document", Base64.encodeFromFile(content));
That has no functional relation with pdf generation so should not be done.
All other code uses Base64 from commons-codec library for example this file in hwmanager:
./org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/pos/process/PrintPDF.java:import org.apache.commons.codec.binary.Base64;
./org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/pos/process/PrintPDF.java: byte[] document = Base64.decodeBase64(content.getString("document"));
Furthermore the itextpdf library has a very specific licensing only allowing it to be used as dependency of jasperreport and does NOT allow any other usage (while wanting to keep LGPL exception)
As that usage above is accidental (probably wrong auto-complete from eclipse) that usage should just be avoided. |
| Steps To Reproduce | legal/iTextpdf_license.txt
Check first paragraph disallowing 'manual usage' |
| Proposed Solution | Don't use Base64 utility from itext |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2020-08-20 15:10 | shuehner | New Issue | |
| 2020-08-20 15:10 | shuehner | Assigned To | => Retail |
| 2020-08-20 15:10 | shuehner | Triggers an Emergency Pack | => No |
| 2020-08-23 16:14 | prakashmurugesan88 | Assigned To | Retail => prakashmurugesan88 |
| 2020-08-24 08:48 | prakashmurugesan88 | Status | new => scheduled |
| 2020-08-24 11:14 | hgbot | Note Added: 0122281 | |
| 2020-08-24 11:15 | hgbot | Note Added: 0122282 | |
| 2020-08-31 13:09 | hgbot | Resolution | open => fixed |
| 2020-08-31 13:09 | hgbot | Status | scheduled => closed |
| 2020-08-31 13:09 | hgbot | Note Added: 0122485 | |
| 2020-08-31 13:10 | hgbot | Fixed in Version | => RR20Q4 |
| 2020-08-31 13:10 | hgbot | Note Added: 0122486 | |
| 2020-08-31 13:10 | hgbot | Note Added: 0122487 | |
| 2020-08-31 13:11 | hgbot | Note Added: 0122488 | |
| 2020-08-31 13:11 | hgbot | Note Added: 0122489 | |
| 2020-08-31 13:11 | hgbot | Note Added: 0122490 | |
|
Notes |
|
|
(0122281)
|
|
hgbot
|
|
2020-08-24 11:14
|
|
|
|
|
(0122282)
|
|
hgbot
|
|
2020-08-24 11:15
|
|
|
|
|
(0122485)
|
|
hgbot
|
|
2020-08-31 13:09
|
|
|
|
|
(0122486)
|
|
hgbot
|
|
2020-08-31 13:10
|
|
|
|
|
(0122487)
|
|
hgbot
|
|
2020-08-31 13:10
|
|
|
|
|
(0122488)
|
|
hgbot
|
|
2020-08-31 13:11
|
|
|
|
|
(0122489)
|
|
hgbot
|
|
2020-08-31 13:11
|
|
|
|
|
(0122490)
|
|
hgbot
|
|
2020-08-31 13:11
|
|
|