Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044827Openbravo ERPA. Platformpublic2020-08-17 13:502020-08-31 10:04
Reportercberner 
Assigned Tocberner 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2019-10-15
Regression introduced in release3.0PR20Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/dded7dec5f17b8b1fc8f6c118af985c5274670a5 [^]
Triggers an Emergency PackNo
Summary0044827: Scheduling a process without start date or start time fails
DescriptionWhen trying to schedule or reschedule a process request without start date or start time it fails with a parse date exception.

In logs:
Couldn't create quartz trigger for process Acct Server Process
java.text.ParseException: Could not parse date
    at org.openbravo.scheduling.SchedulerTimeUtils.parse(SchedulerTimeUtils.java:81) ~[classes/:?]
Steps To Reproduce- Open Process Request
- Create new Process (e.g. Log Clean Up)
- Set to scheduled and empty Start Date or Start Time fields
- Save Process Request and try to schedule it

Check logs -> There's should be a parse date error.
Proposed SolutionIf date/time is missing, use default = now in SchedulerTimeUtils parse function.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0044932PR20Q3.1 closed cberner Scheduling a process without start date or start time fails 
depends on backport 0044933PR20Q2.2 closed cberner Scheduling a process without start date or start time fails 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-17 13:50cbernerNew Issue
2020-08-17 13:50cbernerAssigned To => cberner
2020-08-17 13:50cbernerOBNetwork customer => No
2020-08-17 13:50cbernerModules => Core
2020-08-17 13:50cbernerRegression level => Production - Confirmed Stable
2020-08-17 13:50cbernerRegression date => 2019-10-16
2020-08-17 13:50cbernerRegression introduced in release => 3.0PR20Q1
2020-08-17 13:50cbernerRegression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/0199a62cc7b377ad1f462d282e4925c4d63a8301 [^]
2020-08-17 13:50cbernerTriggers an Emergency Pack => No
2020-08-17 14:41cbernerRegression date2019-10-16 => 2019-10-15
2020-08-17 14:41cbernerRegression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/0199a62cc7b377ad1f462d282e4925c4d63a8301 [^] => https://gitlab.com/openbravo/product/openbravo/-/commit/dded7dec5f17b8b1fc8f6c118af985c5274670a5 [^]
2020-08-21 14:22hgbotMerge Request Status => open
2020-08-21 14:22hgbotNote Added: 0122253
2020-08-31 09:58hgbotMerge Request Statusopen => approved
2020-08-31 10:02cbernerStatusnew => scheduled
2020-08-31 10:04hgbotResolutionopen => fixed
2020-08-31 10:04hgbotStatusscheduled => closed
2020-08-31 10:04hgbotFixed in Version => PR20Q4
2020-08-31 10:04hgbotNote Added: 0122467
2020-08-31 10:04hgbotNote Added: 0122468

Notes
(0122253)
hgbot   
2020-08-21 14:22   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/127 [^]
(0122467)
hgbot   
2020-08-31 10:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 7246213ce9af90cd57e8fac59115759d123f96b3
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-08-31T10:03:35+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/7246213ce9af90cd57e8fac59115759d123f96b3 [^]

Fixes ISSUE-44827: Allow scheduling a process without start date or time

Previously it was possible to schedule a process without start date or
time, assuming current date and current time. This was lost in a
refactor.
A new method getCurrentDateTime has been added to SchedulerTimeUtils to
get the missing part of date/time provided assuming "now" when missing.
It will return the date + time in the expected format for timestamp and
parse.

Fixes regression introduced in commit dded7dec5f17b8b1fc8f6c118af985c5274670a5

---
M src/org/openbravo/scheduling/SchedulerTimeUtils.java
M src/org/openbravo/scheduling/trigger/LaterTriggerGenerator.java
M src/org/openbravo/scheduling/trigger/ScheduledTriggerGenerator.java
---
(0122468)
hgbot   
2020-08-31 10:04   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/127 [^]