Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0044812Openbravo ERP04. Warehouse managementpublic2020-08-13 15:552020-09-07 17:19
Reportershuehner 
Assigned Toinigo_lerga 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q4 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0044812: SL_MInOutTraceReports callout is old-style callout (not SimpleCallout) but also used in manual HTML code
DescriptionThis file was not yet refactored to be a SimpleCallout as it is also used as a Servlet directly from manual HTML code:

Issue 44795 tries to get rid of all callouts registered in ad_callout which are still a Servlet.

Registered as ad_callout here:
./src-db/database/sourcedata/AD_CALLOUT.xml:<!--800007--> <AD_CALLOUT_ID><![CDATA[800007]]></AD_CALLOUT_ID>

Used manually in in 2 files:
src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.html: submitCommandFormParameter('DEFAULT', frmMain.inpLastFieldChanged, changedField, false, null, '../ad_callouts/SL_MInOutTraceReports.html', 'hiddenFrame', null, null, true);
src/org/openbravo/erpCommon/ad_reports/ReportProductMovement.html: submitCommandFormParameter('DEFAULT', frmMain.inpLastFieldChanged, changedField, false, null, '../ad_callouts/SL_MInOutTraceReports.html', 'hiddenFrame', null, null, true);

Checking usage in PI + all modules does not show not any reference to ad_callout _id = 800007.

So when that is verified easy 'fix' would be to change this file to be just a manual servlet (ad_model_object) and remove the ad_callout entry
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0044813 closed inigo_lerga SL_CreateLines_Conversion_UOM callout is old-style callout (not SimpleCallout) but also used in manual HTML code 
blocks design defect 0044795 new Triage Omni OMS Tracking issue to refactor remaining old callouts to extend SimpleCallout 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-08-13 15:55shuehnerNew Issue
2020-08-13 15:55shuehnerAssigned To => Triage Finance
2020-08-13 15:55shuehnerOBNetwork customer => No
2020-08-13 15:55shuehnerModules => Core
2020-08-13 15:55shuehnerTriggers an Emergency Pack => No
2020-08-13 15:56shuehnerRelationship addedblocks 0044795
2020-08-13 15:58shuehnerIssue cloned0044813
2020-08-13 15:58shuehnerRelationship addedrelated to 0044813
2020-08-14 12:49dmiguelezAssigned ToTriage Finance => inigo_lerga
2020-08-21 08:41inigo_lergaStatusnew => scheduled
2020-09-03 12:59hgbotMerge Request Status => open
2020-09-03 12:59hgbotNote Added: 0122587
2020-09-03 13:34inigo_lergaNote Added: 0122588
2020-09-07 09:08inigo_lergaNote Edited: 0122588bug_revision_view_page.php?bugnote_id=0122588#r21631
2020-09-07 09:09inigo_lergaNote Edited: 0122588bug_revision_view_page.php?bugnote_id=0122588#r21632
2020-09-07 09:11inigo_lergaNote Edited: 0122588bug_revision_view_page.php?bugnote_id=0122588#r21633
2020-09-07 09:12inigo_lergaNote Edited: 0122588bug_revision_view_page.php?bugnote_id=0122588#r21634
2020-09-07 17:08dmiguelezNote Edited: 0122588bug_revision_view_page.php?bugnote_id=0122588#r21656
2020-09-07 17:12hgbotNote Added: 0122767
2020-09-07 17:12hgbotMerge Request Statusopen => approved
2020-09-07 17:13hgbotNote Added: 0122768
2020-09-07 17:13hgbotNote Added: 0122769
2020-09-07 17:19hgbotResolutionopen => fixed
2020-09-07 17:19hgbotStatusscheduled => closed
2020-09-07 17:19hgbotNote Added: 0122770
2020-09-07 17:19hgbotFixed in Version => PR20Q4
2020-09-07 17:19hgbotNote Added: 0122771

Notes
(0122587)
hgbot   
2020-09-03 12:59   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/142 [^]
(0122588)
inigo_lerga   
2020-09-03 13:34   
(edited on: 2020-09-07 17:08)
--Test Plan Mantis --
After deleting the AD_CALLOUT entry for this class, there is still an AD_MODEL_OBJECT entry linked to it, which allows Tomcat to be able to make
the Ajax call to the servlet.

As the F&B International Group Admin role in Backend:
  - Go to either Traceability Report window or
    Product Movements Report window and press the Product
    selector button. Select 'Vino Tinto 0,75L' and press the
    OK button.

#In this moment the manual servlet is executed, which inserts the Attribute [CG1000000] in the Attribute selector field"
Check that this value is present in this selector afterwards
(0122767)
hgbot   
2020-09-07 17:12   
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/2 [^]
(0122768)
hgbot   
2020-09-07 17:13   
Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: dbbf25e4f726f21cd6b9039110aea05ca280c44d
Author: david.miguelez <david.miguelez@openbravo.com>
Date: 2020-09-07T17:11:28+02:00
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/dbbf25e4f726f21cd6b9039110aea05ca280c44d [^]

Related to ISSUE-44812. Removed callout entry from Application Dictionary

---
M model/src-db/database/sourcedata/AD_CALLOUT.xml
---
(0122769)
hgbot   
2020-09-07 17:13   
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/2 [^]
(0122770)
hgbot   
2020-09-07 17:19   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/142 [^]
(0122771)
hgbot   
2020-09-07 17:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 1d9ec74bd89b115a2d8757cc093ed72ecfa366a2
Author: inigo_lerga <inigo.lerga@openbravo.com>
Date: 2020-09-07T15:12:56+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/1d9ec74bd89b115a2d8757cc093ed72ecfa366a2 [^]

fixes BUG-44812:Removed SL_MInOutTraceReports callout entry

---
M src-db/database/sourcedata/AD_CALLOUT.xml
---